src/common/mac/HTTPMultipartUpload.m - Issue 1171693007: Use local variable for out parameter rather than direct use of ivar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/common/mac/HTTPMultipartUpload.m

Issue 1171693007: Use local variable for out parameter rather than direct use of ivar (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/common/mac/HTTPMultipartUpload.m

===================================================================

--- src/common/mac/HTTPMultipartUpload.m (revision 1458)

+++ src/common/mac/HTTPMultipartUpload.m (working copy)

@@ -195,10 +195,11 @@

if ([[req URL] isFileURL]) {

[[req HTTPBody] writeToURL:[req URL] options:0 error:error];

} else {

+ NSURLResponse *response = nil;

data = [NSURLConnection sendSynchronousRequest:req

- returningResponse:&response_

+ returningResponse:&response

error:error];

- [response_ retain];

+ response_ = (NSHTTPURLResponse *)[response retain];

}

[req release];

« no previous file with comments | « no previous file | no next file » | no next file with comments »