Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: src/IceTargetLoweringARM32.h

Issue 1171563002: Subzero: Emit ARM build-attributes in the file scope (as header). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: use class final, fix for mips32 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringARM32.h
diff --git a/src/IceTargetLoweringARM32.h b/src/IceTargetLoweringARM32.h
index 53c98951993af7a4d08d0d09230877f74bf250fb..bd7d5284a0ddc42303ce5fa90164cb7ca7417dbd 100644
--- a/src/IceTargetLoweringARM32.h
+++ b/src/IceTargetLoweringARM32.h
@@ -308,8 +308,8 @@ class TargetDataARM32 : public TargetDataLowering {
TargetDataARM32 &operator=(const TargetDataARM32 &) = delete;
public:
- static TargetDataLowering *create(GlobalContext *Ctx) {
- return new TargetDataARM32(Ctx);
+ static std::unique_ptr<TargetDataLowering> create(GlobalContext *Ctx) {
+ return std::unique_ptr<TargetDataLowering>(new TargetDataARM32(Ctx));
}
void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) const final;
@@ -324,6 +324,25 @@ private:
template <typename T> static void emitConstantPool(GlobalContext *Ctx);
};
+class TargetHeaderARM32 final : public TargetHeaderLowering {
+ TargetHeaderARM32() = delete;
+ TargetHeaderARM32(const TargetHeaderARM32 &) = delete;
+ TargetHeaderARM32 &operator=(const TargetHeaderARM32 &) = delete;
+
+public:
+ static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) {
+ return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderARM32(Ctx));
+ }
+
+ void lower();
+
+protected:
+ explicit TargetHeaderARM32(GlobalContext *Ctx);
+
+private:
+ ~TargetHeaderARM32() = default;
+};
+
} // end of namespace Ice
#endif // SUBZERO_SRC_ICETARGETLOWERINGARM32_H

Powered by Google App Engine
This is Rietveld 408576698