Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: src/IceTargetLowering.cpp

Issue 1171563002: Subzero: Emit ARM build-attributes in the file scope (as header). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: use class final, fix for mips32 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLowering.cpp
diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp
index b8f11bbc3f88b55fea343afd5b5563783636d26f..aefad00f989bd6857e55bcf72d831fbada8f7d2d 100644
--- a/src/IceTargetLowering.cpp
+++ b/src/IceTargetLowering.cpp
@@ -437,13 +437,25 @@ TargetDataLowering::createLowering(GlobalContext *Ctx) {
TargetArch Target = Ctx->getFlags().getTargetArch();
#define SUBZERO_TARGET(X) \
if (Target == Target_##X) \
- return std::unique_ptr<TargetDataLowering>(TargetData##X::create(Ctx));
+ return TargetData##X::create(Ctx);
#include "llvm/Config/SZTargets.def"
- llvm_unreachable("Unsupported target data lowering");
- return nullptr;
+ llvm::report_fatal_error("Unsupported target data lowering");
}
TargetDataLowering::~TargetDataLowering() {}
+std::unique_ptr<TargetHeaderLowering>
+TargetHeaderLowering::createLowering(GlobalContext *Ctx) {
+ TargetArch Target = Ctx->getFlags().getTargetArch();
+#define SUBZERO_TARGET(X) \
+ if (Target == Target_##X) \
+ return TargetHeader##X::create(Ctx);
+#include "llvm/Config/SZTargets.def"
+
+ llvm::report_fatal_error("Unsupported target header lowering");
+}
+
+TargetHeaderLowering::~TargetHeaderLowering() {}
+
} // end of namespace Ice

Powered by Google App Engine
This is Rietveld 408576698