Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 1171513002: Reland of Revert of ozone: Remove singleton pattern for SurfaceFactoryOzone. (Closed)

Created:
5 years, 6 months ago by dshwang
Modified:
5 years, 6 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Revert of ozone: Remove singleton pattern for SurfaceFactoryOzone. TBR=sievers (already reviewed) Reason for reland: Fix build for ozone_demo. > Revert of ozone: Remove singleton pattern for SurfaceFactoryOzone. (patchset #1 id:1 of https://codereview.chromium.org/1159493010/) > > Reason for revert: > Broke Linux ChromiumOS compile. > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/17764/steps/compile/logs/stdio#error1 > > Original issue's description: > > ozone: Remove singleton pattern for SurfaceFactoryOzone. > > > > OzonePlatform is sigleton already, so it's not necessary for > > SurfaceFactoryOzone to be singleton. > > > > Committed: https://crrev.com/48b0a7165bd6c9d889fc6d6959a6e59cf7ef9dc6 > > Cr-Commit-Position: refs/heads/master@{#332889} > > TBR=spang@chromium.org,sievers@chromium.org,alexst@chromium.org,dongseong.hwang@intel.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review URL: https://codereview.chromium.org/1167533007 > > Cr-Commit-Position: refs/heads/master@{#332899} Committed: https://crrev.com/9162b5faf0dba619c58c2ce1cb42bcffccc48627 Cr-Commit-Position: refs/heads/master@{#333070}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -57 lines) Patch
M content/browser/compositor/software_output_device_ozone.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation_ozone.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_ozone.cc View 8 chunks +27 lines, -13 lines 0 comments Download
M ui/ozone/demo/software_renderer.cc View 2 chunks +4 lines, -2 lines 1 comment Download
M ui/ozone/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 4 chunks +13 lines, -7 lines 0 comments Download
M ui/ozone/gpu/ozone_gpu.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 3 chunks +5 lines, -12 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dshwang
spang, sievers, could you review again? Previous CL is reverted in https://codereview.chromium.org/1167533007/ because of ozone_demo ...
5 years, 6 months ago (2015-06-05 08:12:02 UTC) #2
spang
lgtm
5 years, 6 months ago (2015-06-05 15:34:18 UTC) #3
spang
TBR sievers there are no changes in that part
5 years, 6 months ago (2015-06-05 15:36:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171513002/1
5 years, 6 months ago (2015-06-05 15:37:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 16:52:49 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 16:54:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9162b5faf0dba619c58c2ce1cb42bcffccc48627
Cr-Commit-Position: refs/heads/master@{#333070}

Powered by Google App Engine
This is Rietveld 408576698