Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1167533007: Revert of ozone: Remove singleton pattern for SurfaceFactoryOzone. (Closed)

Created:
5 years, 6 months ago by Nicolas Zea
Modified:
5 years, 6 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ozone: Remove singleton pattern for SurfaceFactoryOzone. (patchset #1 id:1 of https://codereview.chromium.org/1159493010/) Reason for revert: Broke Linux ChromiumOS compile. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/17764/steps/compile/logs/stdio#error1 Original issue's description: > ozone: Remove singleton pattern for SurfaceFactoryOzone. > > OzonePlatform is sigleton already, so it's not necessary for > SurfaceFactoryOzone to be singleton. > > Committed: https://crrev.com/48b0a7165bd6c9d889fc6d6959a6e59cf7ef9dc6 > Cr-Commit-Position: refs/heads/master@{#332889} TBR=spang@chromium.org,sievers@chromium.org,alexst@chromium.org,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/de77023ebd80bf7f55fc470cb325a7feffd4e2b2 Cr-Commit-Position: refs/heads/master@{#332899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -65 lines) Patch
M content/browser/compositor/software_output_device_ozone.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/gl/gl_implementation_ozone.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/gl/gl_surface_ozone.cc View 8 chunks +13 lines, -27 lines 0 comments Download
M ui/ozone/demo/software_renderer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/ozone/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 4 chunks +7 lines, -13 lines 0 comments Download
M ui/ozone/gpu/ozone_gpu.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 3 chunks +12 lines, -5 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Zea
Created Revert of ozone: Remove singleton pattern for SurfaceFactoryOzone.
5 years, 6 months ago (2015-06-04 20:24:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167533007/1
5 years, 6 months ago (2015-06-04 20:25:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 20:27:42 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 20:28:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de77023ebd80bf7f55fc470cb325a7feffd4e2b2
Cr-Commit-Position: refs/heads/master@{#332899}

Powered by Google App Engine
This is Rietveld 408576698