Issue 1171153002: Port two warning flags from gyp to gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1171153002: Port two warning flags from gyp to gn. (Closed)

Created:
5 years, 6 months ago by Nico

Modified:
5 years, 6 months ago

Reviewers:
hans

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Port two warning flags from gyp to gn. This ports https://codereview.chromium.org/515263002/ and https://codereview.chromium.org/508343002/ I don't see these warnings locally, but they do show up on the bots for some reason. Probably good to have gyp and gn match anyways. BUG=498033 R=hans@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/1b53745be692948b478ff820c42f4422e1f9400c

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	BUILD.gn	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Nico

5 years, 6 months ago (2015-06-09 18:09:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1b53745be692948b478ff820c42f4422e1f9400c (presubmit successful).