Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: BUILD.gn

Issue 1171153002: Port two warning flags from gyp to gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 351fbb10a0bb413e241e1344b4fef46538927d83..3a3a0d6f505786c687813167a7f4f4337cc6fc92 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -72,6 +72,13 @@ config("icu_code") {
"-Wno-tautological-compare",
"-Wno-switch",
]
+ if (is_win) {
+ cflags += [
+ # See http://bugs.icu-project.org/trac/ticket/11122
+ '-Wno-inline-new-delete',
+ '-Wno-implicit-exception-spec-mismatch',
+ ]
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698