GTTF: add an option to pass test filter using a file

GTTF: add an option to pass test filter using a file

This is useful when --gtest_filter on the command line would exceed
command line length limits.

This will be used with chromium_trybot recipe to pass a list of tests
to retry after deapplying the patch.

BUG=236893, 44497
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241833

[sky, 2013-12-18 17:19:58]

https://codereview.chromium.org/117113003/diff/1/base/test/launcher/test_laun...
File base/test/launcher/test_launcher.cc (right):

https://codereview.chromium.org/117113003/diff/1/base/test/launcher/test_laun...
base/test/launcher/test_launcher.cc:674: // Split --gtest_filter at '-', if
there is one, to separate into
I thought you could you multiple - patterns?

[Paweł Hajdan Jr., 2013-12-18 17:50:30]

https://codereview.chromium.org/117113003/diff/1/base/test/launcher/test_laun...
File base/test/launcher/test_launcher.cc (right):

https://codereview.chromium.org/117113003/diff/1/base/test/launcher/test_laun...
base/test/launcher/test_launcher.cc:674: // Split --gtest_filter at '-', if
there is one, to separate into
On 2013/12/18 17:19:59, sky wrote:
> I thought you could you multiple - patterns?

You can. It's
--gtest_filter=Test.Positive1:Test.Positive2:-Test.Negative1:Test.Negative2.

The dash (-) separates the positive part of the filter from the negative, and
both are colon (:) separated lists of patterns.

By the way, there should be no functional change to the gtest_filter logic in
this patch. If there is, it's a bug. :)

[sky, 2013-12-18 21:48:42]

LGTM

https://codereview.chromium.org/117113003/diff/1/base/test/launcher/test_laun...
File base/test/launcher/test_launcher.cc (right):

https://codereview.chromium.org/117113003/diff/1/base/test/launcher/test_laun...
base/test/launcher/test_launcher.cc:674: // Split --gtest_filter at '-', if
there is one, to separate into
On 2013/12/18 17:50:30, Paweł Hajdan Jr. wrote:
> On 2013/12/18 17:19:59, sky wrote:
> > I thought you could you multiple - patterns?
> 
> You can. It's
> --gtest_filter=Test.Positive1:Test.Positive2:-Test.Negative1:Test.Negative2.
> 
> The dash (-) separates the positive part of the filter from the negative, and
> both are colon (:) separated lists of patterns.
> 
> By the way, there should be no functional change to the gtest_filter logic in
> this patch. If there is, it's a bug. :)

I was thinking more of:
Test.Positive1:Test.Positive2:-Test.Negative1:Test.Negative2-Test.Native2

[sky, 2013-12-18 21:49:10]

On 2013/12/18 21:48:42, sky wrote:
> LGTM
> 
>
https://codereview.chromium.org/117113003/diff/1/base/test/launcher/test_laun...
> File base/test/launcher/test_launcher.cc (right):
> 
>
https://codereview.chromium.org/117113003/diff/1/base/test/launcher/test_laun...
> base/test/launcher/test_launcher.cc:674: // Split --gtest_filter at '-', if
> there is one, to separate into
> On 2013/12/18 17:50:30, Paweł Hajdan Jr. wrote:
> > On 2013/12/18 17:19:59, sky wrote:
> > > I thought you could you multiple - patterns?
> > 
> > You can. It's
> > --gtest_filter=Test.Positive1:Test.Positive2:-Test.Negative1:Test.Negative2.
> > 
> > The dash (-) separates the positive part of the filter from the negative,
and
> > both are colon (:) separated lists of patterns.
> > 
> > By the way, there should be no functional change to the gtest_filter logic
in
> > this patch. If there is, it's a bug. :)
> 
> I was thinking more of:
> Test.Positive1:Test.Positive2:-Test.Negative1:Test.Negative2-Test.Native2

I meant:
Test.Positive1:Test.Positive2:-Test.Negative1:Test.Negative2:-Test.Native2

[Paweł Hajdan Jr., 2013-12-19 10:00:00]

Committed patchset #1 manually as r241833 (presubmit successful).

[Paweł Hajdan Jr., 2013-12-19 10:02:07]

On 2013/12/18 21:49:10, sky wrote:
> I meant:
> Test.Positive1:Test.Positive2:-Test.Negative1:Test.Negative2:-Test.Native2

Sorry, it's not obvious to me what that would be expected to do. Feel free to
explain more - please also take a look at
https://code.google.com/p/googletest/wiki/AdvancedGuide#Running_a_Subset_of_t...
, but maybe I'm just missing something.

[sky, 2013-12-19 16:42:12]

I was fine with you landing, hence the LGTM. I was only commenting
that I thought you needed to use the minus for each test you wanted to
exclude. The docs for gclient weren't really clear on this point. I
didn't try looking in the source.

On Thu, Dec 19, 2013 at 2:02 AM,  <phajdan.jr@chromium.org> wrote:
> On 2013/12/18 21:49:10, sky wrote:
>>
>> I meant:
>> Test.Positive1:Test.Positive2:-Test.Negative1:Test.Negative2:-Test.Native2
>
>
> Sorry, it's not obvious to me what that would be expected to do. Feel free
> to
> explain more - please also take a look at
>
https://code.google.com/p/googletest/wiki/AdvancedGuide#Running_a_Subset_of_t...
> , but maybe I'm just missing something.
>
> https://codereview.chromium.org/117113003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.