Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1170963003: Sky: Add a DartConverterEnum and use that for all our enum needs. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 3

Patch Set 4 : 360 no scope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -124 lines) Patch
M sky/engine/bindings/scripts/dart_types.py View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M sky/engine/core/core.gni View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/painting/CanvasGradient.h View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
M sky/engine/core/painting/CanvasGradient.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/painting/Gradient.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/painting/Gradient.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/painting/PaintingStyle.h View 1 2 3 2 chunks +7 lines, -8 lines 0 comments Download
D sky/engine/core/painting/PaintingStyle.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
M sky/engine/core/painting/TransferMode.h View 2 chunks +8 lines, -9 lines 0 comments Download
D sky/engine/core/painting/TransferMode.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
M sky/engine/core/script/dom_dart_state.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/script/dom_dart_state.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M sky/engine/tonic/dart_converter.h View 3 chunks +20 lines, -2 lines 0 comments Download
M sky/engine/tonic/dart_state.h View 4 chunks +7 lines, -1 line 0 comments Download
M sky/engine/tonic/dart_state.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Matt Perry
5 years, 6 months ago (2015-06-09 19:45:56 UTC) #2
eseidel
lgtm You're fantastic. Thank you very much!
5 years, 6 months ago (2015-06-09 19:48:57 UTC) #3
abarth-chromium
https://codereview.chromium.org/1170963003/diff/40001/sky/engine/tonic/dart_state.cc File sky/engine/tonic/dart_state.cc (right): https://codereview.chromium.org/1170963003/diff/40001/sky/engine/tonic/dart_state.cc#newcode39 sky/engine/tonic/dart_state.cc:39: DidSetIsolate(); Do we want dart_scope to be on the ...
5 years, 6 months ago (2015-06-09 19:51:38 UTC) #5
Matt Perry
https://codereview.chromium.org/1170963003/diff/40001/sky/engine/tonic/dart_state.cc File sky/engine/tonic/dart_state.cc (right): https://codereview.chromium.org/1170963003/diff/40001/sky/engine/tonic/dart_state.cc#newcode39 sky/engine/tonic/dart_state.cc:39: DidSetIsolate(); On 2015/06/09 19:51:37, abarth wrote: > Do we ...
5 years, 6 months ago (2015-06-09 19:52:47 UTC) #6
Matt Perry
https://codereview.chromium.org/1170963003/diff/40001/sky/engine/tonic/dart_state.cc File sky/engine/tonic/dart_state.cc (right): https://codereview.chromium.org/1170963003/diff/40001/sky/engine/tonic/dart_state.cc#newcode39 sky/engine/tonic/dart_state.cc:39: DidSetIsolate(); On 2015/06/09 19:52:47, Matt Perry wrote: > On ...
5 years, 6 months ago (2015-06-09 19:55:40 UTC) #7
abarth-chromium
LGTM
5 years, 6 months ago (2015-06-09 19:56:41 UTC) #8
Matt Perry
5 years, 6 months ago (2015-06-09 19:58:57 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
3c932f9d4b3cd039da2b7628a9e94a0742796278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698