Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: sky/engine/core/painting/TransferMode.h

Issue 1170963003: Sky: Add a DartConverterEnum and use that for all our enum needs. (Closed) Base URL: git@github.com:/domokit/mojo.git@master
Patch Set: 360 no scope Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/painting/PaintingStyle.cpp ('k') | sky/engine/core/painting/TransferMode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/painting/TransferMode.h
diff --git a/sky/engine/core/painting/TransferMode.h b/sky/engine/core/painting/TransferMode.h
index 6033f4d250be888d0ca1dac6b235de34b6d6c90d..fd90c6b88c5eb15e6d00d71e1725454d4ad1fdc8 100644
--- a/sky/engine/core/painting/TransferMode.h
+++ b/sky/engine/core/painting/TransferMode.h
@@ -5,10 +5,7 @@
#ifndef SKY_ENGINE_CORE_PAINTING_TRANSFERMODE_H_
#define SKY_ENGINE_CORE_PAINTING_TRANSFERMODE_H_
-#include "sky/engine/core/painting/Rect.h"
-#include "sky/engine/tonic/dart_wrappable.h"
-#include "sky/engine/wtf/PassRefPtr.h"
-#include "sky/engine/wtf/RefCounted.h"
+#include "sky/engine/tonic/dart_converter.h"
#include "third_party/skia/include/core/SkXfermode.h"
namespace blink {
@@ -16,11 +13,13 @@ namespace blink {
class TransferMode {};
template <>
-struct DartConverter<TransferMode> {
- static SkXfermode::Mode FromArgumentsWithNullCheck(Dart_NativeArguments args,
- int index,
- Dart_Handle& exception);
-};
+struct DartConverter<TransferMode>
+ : public DartConverterEnum<SkXfermode::Mode> {};
+
+// If this fails, it's because SkXfermode has changed. We need to change
+// TransferMode.dart to ensure the TransferMode enum is in sync with the C++
+// values.
+COMPILE_ASSERT(SkXfermode::kLastMode == 28, Need_to_update_TransferMode_dart);
} // namespace blink
« no previous file with comments | « sky/engine/core/painting/PaintingStyle.cpp ('k') | sky/engine/core/painting/TransferMode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698