Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1170843005: Enable setVisibleOnAllWorkspaces on stable. (Closed)

Created:
5 years, 6 months ago by jackhou1
Modified:
5 years, 6 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable setVisibleOnAllWorkspaces on stable. This was made stable in https://codereview.chromium.org/866893003 but that CL missed this is-dev-channel check. BUG=495039, 384644 Committed: https://crrev.com/48f69f66f31037a1ee6d3c9e7b4a69c4ecd12ad4 Cr-Commit-Position: refs/heads/master@{#333648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
benwells, please take a look
5 years, 6 months ago (2015-06-09 01:32:43 UTC) #2
benwells
lgtm
5 years, 6 months ago (2015-06-10 00:59:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170843005/1
5 years, 6 months ago (2015-06-10 01:10:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 02:07:35 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 02:08:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48f69f66f31037a1ee6d3c9e7b4a69c4ecd12ad4
Cr-Commit-Position: refs/heads/master@{#333648}

Powered by Google App Engine
This is Rietveld 408576698