lib/src/checker/resolver.dart - Issue 1170813008: fixes detection of SDK libraries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/checker/resolver.dart

Issue 1170813008: fixes detection of SDK libraries (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: format Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/checker/resolver.dart

diff --git a/lib/src/checker/resolver.dart b/lib/src/checker/resolver.dart

index 5032888b3174a500014cbf4cde95d84445c2bef4..bd080e970ba0fea76194e9e139a008b9a3834bfb 100644

--- a/lib/src/checker/resolver.dart

+++ b/lib/src/checker/resolver.dart

@@ -595,9 +595,7 @@ class RestrictedStaticTypeAnalyzer extends StaticTypeAnalyzer {

}

var e = node.methodName.staticElement;

- if (e is FunctionElement &&

- e.library.name == '_foreign_helper' &&

- e.name == 'JS') {

+ if (isInlineJS(e)) {

// Fix types for JS builtin calls.

// This code was taken from analyzer. It's not super sophisticated: