Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: lib/devc.dart

Issue 1170813008: fixes detection of SDK libraries (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: format Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/runtime/dart/_isolate_helper.js » ('j') | lib/src/codegen/js_module_item_order.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/devc.dart
diff --git a/lib/devc.dart b/lib/devc.dart
index 4415f86c86f50a7733f52f41217b4d226bac6771..6972be3271ef332a40de810270fc26c5e2513689 100644
--- a/lib/devc.dart
+++ b/lib/devc.dart
@@ -155,7 +155,7 @@ class Compiler implements AbstractCompiler {
context.applyChanges(new ChangeSet()..changedSource(source));
var entryUnit = context.resolveCompilationUnit2(source, source);
var lib = entryUnit.element.enclosingElement;
- if (!options.checkSdk && lib.isInSdk) return;
+ if (!options.checkSdk && lib.source.uri.scheme == 'dart') return;
vsm 2015/06/10 16:41:15 Move _isDartUri to utils and call that instead?
Jennifer Messerly 2015/06/10 16:46:04 funny, almost did that. The thing is, now it becom
var current = node.info;
if (current != null) {
assert(current.library == lib);
« no previous file with comments | « no previous file | lib/runtime/dart/_isolate_helper.js » ('j') | lib/src/codegen/js_module_item_order.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698