Initial Timeline Events

runtime/vm/compiler.cc

Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index 57cfa7f6026391418fd2cf1aa5a61bd5c75b1954..2d31344adc25507361e96569d9170af52e31633e 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -1068,7 +1068,10 @@ static RawError* CompileFunctionHelper(CompilationPipeline* pipeline,
 
 RawError* Compiler::CompileFunction(Thread* thread,
                                     const Function& function) {
-  VMTagScope tagScope(thread->isolate(), VMTag::kCompileUnoptimizedTagId);
+  Isolate* isolate = thread->isolate();
+  VMTagScope tagScope(isolate, VMTag::kCompileUnoptimizedTagId);
+  TimelineDurationScope tds(isolate->GetCompilerStream(), "CompileFunction");
+  tds.SetArgument("function", function.PrettyNameCString());

[rmacnak, 2015/06/05 21:22:58]

Is this string in the right zone? Doesn't the current zone go away when
compilation finishes?

Probably should be a qualified name so we have a chance of identifying the
function later.

[Cutch, 2015/06/05 21:34:43]

The string is copied when stored in the Event.
Agreed.

   CompilationPipeline* pipeline =
       CompilationPipeline::New(thread->zone(), function);
 
@@ -1113,7 +1116,11 @@ RawError* Compiler::EnsureUnoptimizedCode(Thread* thread,
 RawError* Compiler::CompileOptimizedFunction(Thread* thread,
                                              const Function& function,
                                              intptr_t osr_id) {
-  VMTagScope tagScope(thread->isolate(), VMTag::kCompileOptimizedTagId);
+  Isolate* isolate = thread->isolate();
+  VMTagScope tagScope(isolate, VMTag::kCompileOptimizedTagId);
+  TimelineDurationScope tds(isolate->GetCompilerStream(),
+                            "CompileOptimizedFunction");

[siva, 2015/06/09 22:37:56]

VMTagScope and TimelineDurationScope seem to always show up together, I wonder
if it makes sense to have a convenience macro.

[Cutch, 2015/06/10 18:20:56]

Acknowledged.

+  tds.SetArgument("function", function.PrettyNameCString());
   CompilationPipeline* pipeline =
       CompilationPipeline::New(thread->zone(), function);
   return CompileFunctionHelper(pipeline, function, true, osr_id);