Initial Timeline Events

runtime/vm/compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/compiler.h"
 
 #include "vm/assembler.h"
 
 #include "vm/ast_printer.h"
 #include "vm/block_scheduler.h"
@@ skipping 1050 matching lines @@
     isolate->object_store()->clear_sticky_error();
     return error.raw();
   }
   UNREACHABLE();
   return Error::null();
 }
 
 
 RawError* Compiler::CompileFunction(Thread* thread,
                                     const Function& function) {
-  VMTagScope tagScope(thread->isolate(), VMTag::kCompileUnoptimizedTagId);
+  Isolate* isolate = thread->isolate();
+  VMTagScope tagScope(isolate, VMTag::kCompileUnoptimizedTagId);
+  TimelineDurationScope tds(isolate->GetCompilerStream(), "CompileFunction");
+  tds.SetArgument("function", function.PrettyNameCString());

[rmacnak, 2015/06/05 21:22:58]

Is this string in the right zone? Doesn't the current zone go away when
compilation finishes?

Probably should be a qualified name so we have a chance of identifying the
function later.

[Cutch, 2015/06/05 21:34:43]

The string is copied when stored in the Event.
Agreed.

   CompilationPipeline* pipeline =
       CompilationPipeline::New(thread->zone(), function);
 
   const bool optimized =
       Compiler::always_optimize() && function.IsOptimizable();
 
   return CompileFunctionHelper(pipeline, function, optimized,
       Isolate::kNoDeoptId);
 }
 
@@ skipping 24 matching lines @@
   if (FLAG_trace_compiler) {
     ISL_Print("Ensure unoptimized code for %s\n", function.ToCString());
   }
   return Error::null();
 }
 
 
 RawError* Compiler::CompileOptimizedFunction(Thread* thread,
                                              const Function& function,
                                              intptr_t osr_id) {
-  VMTagScope tagScope(thread->isolate(), VMTag::kCompileOptimizedTagId);
+  Isolate* isolate = thread->isolate();
+  VMTagScope tagScope(isolate, VMTag::kCompileOptimizedTagId);
+  TimelineDurationScope tds(isolate->GetCompilerStream(),
+                            "CompileOptimizedFunction");

[siva, 2015/06/09 22:37:56]

VMTagScope and TimelineDurationScope seem to always show up together, I wonder
if it makes sense to have a convenience macro.

[Cutch, 2015/06/10 18:20:56]

Acknowledged.

+  tds.SetArgument("function", function.PrettyNameCString());
   CompilationPipeline* pipeline =
       CompilationPipeline::New(thread->zone(), function);
   return CompileFunctionHelper(pipeline, function, true, osr_id);
 }
 
 
 // This is only used from unit tests.
 RawError* Compiler::CompileParsedFunction(
     ParsedFunction* parsed_function) {
   LongJumpScope jump;
@@ skipping 197 matching lines @@
     const Object& result =
       PassiveObject::Handle(isolate->object_store()->sticky_error());
     isolate->object_store()->clear_sticky_error();
     return result.raw();
   }
   UNREACHABLE();
   return Object::null();
 }
 
 }  // namespace dart