Fix crash when opening up the status tray.

Fix rare crash when opening up the status tray.

BUG=497282
Committed: https://crrev.com/952985e3821fea40f284004cae13795f8a3db489
Cr-Commit-Position: refs/heads/master@{#333596}

[jdufault, 2015-06-08 20:53:29]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org, jennyz@chromium.org

[jdufault, 2015-06-08 20:57:11]

On 2015/06/08 20:53:29, jdufault wrote:
> mailto:jdufault@chromium.org changed reviewers:
> + mailto:achuith@chromium.org, mailto:jennyz@chromium.org

I haven't been able to reproduce the issue, so this is my best-guess as to what
is wrong.

Looking at the stack traces, it looks like the CastSelectDefaultView instance is
garbage data (it is either 0x0000 or the first pointer deref offset from this
fails). Using a weak pointer will alleviate this issue.

I also added the weak_ptr logic to the other base::Bind invocations, since they
should also be prone to the same type of crash.

[achuithb, 2015-06-08 22:32:03]

lgtm. Sorry this was my quick and dirty code.

https://codereview.chromium.org/1169903002/diff/1/ash/system/cast/tray_cast.cc
File ash/system/cast/tray_cast.cc (right):

https://codereview.chromium.org/1169903002/diff/1/ash/system/cast/tray_cast.c...
ash/system/cast/tray_cast.cc:427: options_(nullptr),
let's move this initializer to the class definition

[jdufault, 2015-06-08 23:07:44]

https://codereview.chromium.org/1169903002/diff/1/ash/system/cast/tray_cast.cc
File ash/system/cast/tray_cast.cc (right):

https://codereview.chromium.org/1169903002/diff/1/ash/system/cast/tray_cast.c...
ash/system/cast/tray_cast.cc:427: options_(nullptr),
On 2015/06/08 22:32:03, achuithb wrote:
> let's move this initializer to the class definition

Done.

[jennyz, 2015-06-09 21:04:55]

lgtm

[jdufault, 2015-06-09 21:06:08]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2015-06-09 21:06:08]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/1169903002/#ps20001
(title: "Perform initialization in class body")

[commit-bot: I haz the power, 2015-06-09 21:08:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169903002/20001

[commit-bot: I haz the power, 2015-06-09 22:25:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-09 22:26:34]

Patchset 2 (id:??) landed as
https://crrev.com/952985e3821fea40f284004cae13795f8a3db489
Cr-Commit-Position: refs/heads/master@{#333596}