Fix crash when opening up the status tray.

ash/system/cast/tray_cast.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/cast/tray_cast.h"
 
 #include "ash/session/session_state_delegate.h"
 #include "ash/shelf/shelf_types.h"
 #include "ash/shell.h"
 #include "ash/system/chromeos/screen_security/screen_tray_item.h"
@@ skipping 42 matching lines @@
 
   // Updates the label based on the current set of receivers (if there are or
   // are not any available receivers).
   void UpdateLabel();
 
  private:
   void UpdateLabelCallback(
       const CastConfigDelegate::ReceiversAndActivites& receivers_activities);
 
   CastConfigDelegate* cast_config_delegate_;
+  base::WeakPtrFactory<CastSelectDefaultView> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(CastSelectDefaultView);
 };
 
 CastSelectDefaultView::CastSelectDefaultView(
     SystemTrayItem* owner,
     CastConfigDelegate* cast_config_delegate,
     bool show_more)
     : TrayItemMore(owner, show_more),
-      cast_config_delegate_(cast_config_delegate) {
+      cast_config_delegate_(cast_config_delegate),
+      weak_ptr_factory_(this) {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   SetImage(rb.GetImageNamed(IDR_AURA_UBER_TRAY_CAST).ToImageSkia());
 
   // We first set a default label before we actually know what the label will
   // be, because it could take awhile before UpdateLabel() actually applies
   // the correct label.
   SetLabel(rb.GetLocalizedString(IDS_ASH_STATUS_TRAY_CAST_NO_DEVICE));
   UpdateLabel();
 }
 
@@ skipping 10 matching lines @@
   SetLabel(label);
   SetAccessibleName(label);
   SetVisible(true);
 }
 
 void CastSelectDefaultView::UpdateLabel() {
   if (cast_config_delegate_ == nullptr ||
       cast_config_delegate_->HasCastExtension() == false)
     return;
 
-  cast_config_delegate_->GetReceiversAndActivities(base::Bind(
-      &CastSelectDefaultView::UpdateLabelCallback, base::Unretained(this)));
+  cast_config_delegate_->GetReceiversAndActivities(
+      base::Bind(&CastSelectDefaultView::UpdateLabelCallback,
+                 weak_ptr_factory_.GetWeakPtr()));
 }
 
 // This view is displayed when the screen is actively being casted; it allows
 // the user to easily stop casting. It fully replaces the
 // |CastSelectDefaultView| view inside of the |CastDuplexView|.
 class CastCastView : public views::View, public views::ButtonListener {
  public:
   explicit CastCastView(CastConfigDelegate* cast_config_delegate);
   ~CastCastView() override;
 
   // Updates the label for the stop view to include information about the
   // current device that is being casted.
   void UpdateLabel();
 
  private:
   void UpdateLabelCallback(
       const CastConfigDelegate::ReceiversAndActivites& receivers_activities);
 
   // Overridden from views::View.
   void Layout() override;
   // Overridden from views::ButtonListener
   void ButtonPressed(views::Button* sender, const ui::Event& event) override;
 
   CastConfigDelegate* cast_config_delegate_;
   views::ImageView* icon_;
   views::View* label_container_;
   views::Label* title_;
   views::Label* details_;
   TrayPopupLabelButton* stop_button_;
+  base::WeakPtrFactory<CastCastView> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CastCastView);
 };
 
 CastCastView::CastCastView(CastConfigDelegate* cast_config_delegate)
-    : cast_config_delegate_(cast_config_delegate) {
+    : cast_config_delegate_(cast_config_delegate), weak_ptr_factory_(this) {
   // We will initialize the primary tray view which shows a stop button here.
 
   set_background(views::Background::CreateSolidBackground(kBackgroundColor));
   ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
   SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal,
                                         kTrayPopupPaddingHorizontal, 0,
                                         kTrayPopupPaddingBetweenItems));
   icon_ = new FixedSizedImageView(0, kTrayPopupItemHeight);
   icon_->SetImage(
       bundle.GetImageNamed(IDR_AURA_UBER_TRAY_CAST_ENABLED).ToImageSkia());
@@ skipping 60 matching lines @@
   const int extra_height =
       height() - label_container_->GetPreferredSize().height();
   label_container_->SetY(extra_height / 2);
 }
 
 void CastCastView::UpdateLabel() {
   if (cast_config_delegate_ == nullptr ||
       cast_config_delegate_->HasCastExtension() == false)
     return;
 
-  cast_config_delegate_->GetReceiversAndActivities(
-      base::Bind(&CastCastView::UpdateLabelCallback, base::Unretained(this)));
+  cast_config_delegate_->GetReceiversAndActivities(base::Bind(
+      &CastCastView::UpdateLabelCallback, weak_ptr_factory_.GetWeakPtr()));
 }
 
 void CastCastView::UpdateLabelCallback(
     const CastConfigDelegate::ReceiversAndActivites& receivers_activities) {
   for (auto& i : receivers_activities) {
     const CastConfigDelegate::Receiver receiver = i.second.receiver;
     const CastConfigDelegate::Activity activity = i.second.activity;
     if (!activity.id.empty()) {
       // We want to display different labels inside of the title depending on
       // what we are actually casting - either the desktop, a tab, or a fallback
@@ skipping 167 matching lines @@
       const CastConfigDelegate::ReceiverAndActivity& receiverActivity);
 
   void AppendSettingsEntries();
   void AppendHeaderEntry();
 
   // Overridden from ViewClickListener.
   void OnViewClicked(views::View* sender) override;
 
   CastConfigDelegate* cast_config_delegate_;
   user::LoginStatus login_;
-  views::View* options_;
+  views::View* options_ = nullptr;
   CastConfigDelegate::ReceiversAndActivites receivers_and_activities_;
   // A mapping from the view pointer to the associated activity id
   std::map<views::View*, std::string> receiver_activity_map_;
+  base::WeakPtrFactory<CastDetailedView> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CastDetailedView);
 };
 
 CastDetailedView::CastDetailedView(SystemTrayItem* owner,
                                    CastConfigDelegate* cast_config_delegate,
                                    user::LoginStatus login)
     : TrayDetailsView(owner),
       cast_config_delegate_(cast_config_delegate),
       login_(login),
-      options_(nullptr) {
+      weak_ptr_factory_(this) {
   CreateItems();
   UpdateReceiverList();
 }
 
 CastDetailedView::~CastDetailedView() {
 }
 
 void CastDetailedView::CreateItems() {
   CreateScrollableList();
   AppendSettingsEntries();
   AppendHeaderEntry();
 }
 
 void CastDetailedView::UpdateReceiverList() {
-  cast_config_delegate_->GetReceiversAndActivities(base::Bind(
-      &CastDetailedView::UpdateReceiverListCallback, base::Unretained(this)));
+  cast_config_delegate_->GetReceiversAndActivities(
+      base::Bind(&CastDetailedView::UpdateReceiverListCallback,
+                 weak_ptr_factory_.GetWeakPtr()));
 }
 
 void CastDetailedView::UpdateReceiverListCallback(
     const CastConfigDelegate::ReceiversAndActivites&
         new_receivers_and_activities) {
   // Add/update existing.
   for (auto i = new_receivers_and_activities.begin();
        i != new_receivers_and_activities.end(); ++i) {
     receivers_and_activities_[i->first] = i->second;
   }
@@ skipping 166 matching lines @@
   is_casting_ = started;
   UpdatePrimaryView();
 }
 
 void TrayCast::UpdateAfterShelfAlignmentChange(ShelfAlignment alignment) {
   if (tray_)
     tray_->UpdateAlignment(alignment);
 }
 
 }  // namespace ash