Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1169853008: Rename the confusingly named "ContentNode" class to "TagNode". (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename the confusingly named "ContentNode" class to "TagNode". Also considered "AnnotationNode", "LabelNode", "BadgeNode", but "TagNode" seemed simplest. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7d80dde42d6763173a2f6c674899e9fe2b99ef19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M sky/sdk/lib/framework/fn2.dart View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-09 19:42:59 UTC) #2
Hixie
5 years, 6 months ago (2015-06-09 19:44:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d80dde42d6763173a2f6c674899e9fe2b99ef19 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698