Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: sky/sdk/lib/framework/fn2.dart

Issue 1169853008: Rename the confusingly named "ContentNode" class to "TagNode". (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/fn2.dart
diff --git a/sky/sdk/lib/framework/fn2.dart b/sky/sdk/lib/framework/fn2.dart
index 69aaf7ad5e588e7f8b22582e48d756b402600933..40cc835fbc6be9607ae4ab2155fadafef0f79ae5 100644
--- a/sky/sdk/lib/framework/fn2.dart
+++ b/sky/sdk/lib/framework/fn2.dart
@@ -153,13 +153,16 @@ abstract class UINode {
}
}
-abstract class ContentNode extends UINode {
+// Descendants of TagNode provide a way to tag RenderObjectWrapper and
+// Component nodes with annotations, such as event listeners,
+// stylistic information, etc.
+abstract class TagNode extends UINode {
UINode content;
- ContentNode(UINode content, { Object key }) : this.content = content, super(key: key);
+ TagNode(UINode content, { Object key }) : this.content = content, super(key: key);
void _sync(UINode old, dynamic slot) {
- UINode oldContent = old == null ? null : (old as ContentNode).content;
+ UINode oldContent = old == null ? null : (old as TagNode).content;
content = syncChild(content, oldContent, slot);
assert(content.root != null);
root = content.root;
@@ -172,7 +175,7 @@ abstract class ContentNode extends UINode {
}
}
-class ParentDataNode extends ContentNode {
+class ParentDataNode extends TagNode {
final ParentData parentData;
ParentDataNode(UINode content, this.parentData, { Object key }): super(content, key: key);
@@ -182,7 +185,7 @@ typedef void GestureEventListener(sky.GestureEvent e);
typedef void PointerEventListener(sky.PointerEvent e);
typedef void EventListener(sky.Event e);
-class EventListenerNode extends ContentNode {
+class EventListenerNode extends TagNode {
final Map<String, sky.EventListener> listeners;
static Map<String, sky.EventListener> _createListeners({
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698