Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: BUILD.gn

Issue 1169853007: Make js2c depend on messages.h (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/d8.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 2f108d0803ef0e3995288f9ba1d2d3ecfa8a01bb..62863621ff2a6824e01aa86c548bc5f07b2f2fdd 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -196,9 +196,12 @@ action("js2c") {
script = "tools/js2c.py"
- # The script depends on this other script, this rule causes a rebuild if it
- # changes.
- inputs = [ "tools/jsmin.py" ]
+ # The script depends on these other files, this rule causes a rebuild if any
+ # of them changes.
+ inputs = [
+ "tools/jsmin.py",
+ "src/messages.h",
+ ]
sources = [
"src/macros.py",
@@ -260,9 +263,12 @@ action("js2c_experimental") {
script = "tools/js2c.py"
- # The script depends on this other script, this rule causes a rebuild if it
- # changes.
- inputs = [ "tools/jsmin.py" ]
+ # The script depends on these other files, this rule causes a rebuild if any
+ # of them changes.
+ inputs = [
+ "tools/jsmin.py",
+ "src/messages.h",
+ ]
sources = [
"src/macros.py",
@@ -305,9 +311,12 @@ action("js2c_extras") {
script = "tools/js2c.py"
- # The script depends on this other script, this rule causes a rebuild if it
- # changes.
- inputs = [ "tools/jsmin.py" ]
+ # The script depends on these other files, this rule causes a rebuild if any
+ # of them changes.
+ inputs = [
+ "tools/jsmin.py",
+ "src/messages.h",
arv (Not doing code reviews) 2015/06/09 16:16:22 I don't think js2c_extras depends on this but I'm
domenic 2015/06/09 16:24:56 Yeah I checked and it doesn't. BuildFilterChain vs
+ ]
sources = v8_extra_library_files
@@ -338,6 +347,7 @@ action("d8_js2c") {
inputs = [
"src/d8.js",
"src/macros.py",
+ "src/messages.h',
]
outputs = [
« no previous file with comments | « no previous file | src/d8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698