Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1169853007: Make js2c depend on messages.h (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
CC:
v8-dev, vogelheim, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make js2c depend on messages.h messages.h defined the constants used for error messages. The js2c target needs to be rebuilt when messages.h changes. BUG=N LOG=N R=machenbach@chromium.org, yang@chromium.org, domenic@chromium.org

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M BUILD.gn View 4 chunks +19 lines, -9 lines 2 comments Download
M src/d8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
arv (Not doing code reviews)
PTAL https://codereview.chromium.org/1169853007/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1169853007/diff/1/BUILD.gn#newcode318 BUILD.gn:318: "src/messages.h", I don't think js2c_extras depends on this ...
5 years, 6 months ago (2015-06-09 16:16:22 UTC) #1
domenic
https://codereview.chromium.org/1169853007/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1169853007/diff/1/BUILD.gn#newcode318 BUILD.gn:318: "src/messages.h", On 2015/06/09 at 16:16:22, arv wrote: > I ...
5 years, 6 months ago (2015-06-09 16:24:56 UTC) #2
domenic
lgtm
5 years, 6 months ago (2015-06-09 16:25:46 UTC) #3
domenic
On 2015/06/09 at 16:25:46, domenic wrote: > lgtm ... except the gn build is failing ...
5 years, 6 months ago (2015-06-09 16:26:53 UTC) #4
arv (Not doing code reviews)
I don't think this CL is correct. Now that I look at it closer, all ...
5 years, 6 months ago (2015-06-09 16:32:57 UTC) #5
Michael Achenbach
CC vogelheim@chromium.org who works on a fix for some of the missing dependencies. Looks like ...
5 years, 6 months ago (2015-06-10 10:09:52 UTC) #6
arv (Not doing code reviews)
5 years, 6 months ago (2015-06-10 13:55:24 UTC) #7
Closing this since this is not the problem

Powered by Google App Engine
This is Rietveld 408576698