Make js2c depend on messages.h

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/mips.gni")
 
 # Because standalone V8 builds are not supported, assume this is part of a
 # Chromium build.
@@ skipping 178 matching lines @@
 
 ###############################################################################
 # Actions
 #
 
 action("js2c") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   script = "tools/js2c.py"
 
-  # The script depends on this other script, this rule causes a rebuild if it
-  # changes.
-  inputs = [ "tools/jsmin.py" ]
+  # The script depends on these other files, this rule causes a rebuild if any
+  # of them changes.
+  inputs = [
+    "tools/jsmin.py",
+    "src/messages.h",
+  ]
 
   sources = [
     "src/macros.py",
     "src/messages.h",
     "src/runtime.js",
     "src/prologue.js",
     "src/v8natives.js",
     "src/symbol.js",
     "src/array.js",
     "src/string.js",
@@ skipping 41 matching lines @@
       rebase_path("$target_gen_dir/libraries.bin", root_build_dir),
     ]
   }
 }
 
 action("js2c_experimental") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   script = "tools/js2c.py"
 
-  # The script depends on this other script, this rule causes a rebuild if it
-  # changes.
-  inputs = [ "tools/jsmin.py" ]
+  # The script depends on these other files, this rule causes a rebuild if any
+  # of them changes.
+  inputs = [
+    "tools/jsmin.py",
+    "src/messages.h",
+  ]
 
   sources = [
     "src/macros.py",
     "src/messages.h",
     "src/proxy.js",
     "src/generator.js",
     "src/harmony-atomics.js",
     "src/harmony-array.js",
     "src/harmony-array-includes.js",
     "src/harmony-typedarray.js",
@@ skipping 22 matching lines @@
       rebase_path("$target_gen_dir/libraries_experimental.bin", root_build_dir),
     ]
   }
 }
 
 action("js2c_extras") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   script = "tools/js2c.py"
 
-  # The script depends on this other script, this rule causes a rebuild if it
-  # changes.
-  inputs = [ "tools/jsmin.py" ]
+  # The script depends on these other files, this rule causes a rebuild if any
+  # of them changes.
+  inputs = [
+    "tools/jsmin.py",
+    "src/messages.h",

[arv (Not doing code reviews), 2015/06/09 16:16:22]

I don't think js2c_extras depends on this but I'm not really sure?

[domenic, 2015/06/09 16:24:56]

Yeah I checked and it doesn't. BuildFilterChain vs. BuildExtraFilterChain.

+  ]
 
   sources = v8_extra_library_files
 
   outputs = [
     "$target_gen_dir/extras-libraries.cc",
   ]
 
   args = [
            rebase_path("$target_gen_dir/extras-libraries.cc",
                        root_build_dir),
@@ skipping 10 matching lines @@
 }
 
 action("d8_js2c") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   script = "tools/js2c.py"
 
   inputs = [
     "src/d8.js",
     "src/macros.py",
+    "src/messages.h',
   ]
 
   outputs = [
     "$target_gen_dir/d8-js.cc",
   ]
 
   args = rebase_path(outputs, root_build_dir) + [ "D8" ] +
          rebase_path(inputs, root_build_dir)
 }
 
@@ skipping 1327 matching lines @@
       sources += [
         "src/d8-debug.cc",
         "$target_gen_dir/d8-js.cc",
       ]
     }
     if (v8_enable_i18n_support) {
       deps += [ "//third_party/icu" ]
     }
   }
 }