[es6] Parsing of new.target

[es6] Parsing of new.target

BUG=v8:3887
LOG=N
R=adamk@chromium.org, dslomov@chromium.org

Committed: https://crrev.com/ae06bdde7763d673b39948b710df414217265cce
Cr-Commit-Position: refs/heads/master@{#28865}

[arv (Not doing code reviews), 2015-06-08 19:56:44]

PTAL

Everytime I go back to do new.target I end up having to do this work (which bit
rots over time). I might as well commit this since this part is working fine.

https://codereview.chromium.org/1169853002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1169853002/diff/1/src/parser.cc#newcode795
src/parser.cc:795: Variable::NORMAL, pos, pos + 10);
Is there a way to get the length of "new.target" at compile time?

[Dmitry Lomov (no reviews), 2015-06-09 09:57:23]

lgtm

https://codereview.chromium.org/1169853002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1169853002/diff/1/src/parser.cc#newcode795
src/parser.cc:795: Variable::NORMAL, pos, pos + 10);
On 2015/06/08 19:56:44, arv wrote:
> Is there a way to get the length of "new.target" at compile time?

Maybe add a constant?

[arv (Not doing code reviews), 2015-06-09 13:55:43]

Add constant

[arv (Not doing code reviews), 2015-06-09 13:55:54]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-06-09 13:55:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dslomov@chromium.org
Link to the patchset: https://codereview.chromium.org/1169853002/#ps20001
(title: "Add constant")

[commit-bot: I haz the power, 2015-06-09 13:56:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169853002/20001

[commit-bot: I haz the power, 2015-06-09 14:28:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-09 14:28:18]

Patchset 2 (id:??) landed as
https://crrev.com/ae06bdde7763d673b39948b710df414217265cce
Cr-Commit-Position: refs/heads/master@{#28865}

[Michael Achenbach, 2015-06-09 15:11:28]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1170263002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] fails messages:
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20sn....

[arv (Not doing code reviews), 2015-06-09 15:30:20]

On 2015/06/09 15:11:28, Michael Achenbach wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1170263002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] fails messages:
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20sn....

Micael, I talked to Yang about this and this CL is fine (it passed after I
clobbered it). There seems to be an issue where js2c is not being rebuilt.

Reverting revert...

[arv (Not doing code reviews), 2015-06-09 15:30:49]

On 2015/06/09 15:30:20, arv wrote:
> On 2015/06/09 15:11:28, Michael Achenbach wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/1170263002/ by
mailto:machenbach@chromium.org.
> > 
> > The reason for reverting is: [Sheriff] fails messages:
> >
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20sn....
> 
> Micael, I talked to Yang about this and this CL is fine (it passed after I
> clobbered it). There seems to be an issue where js2c is not being rebuilt.
> 
> Reverting revert...

Sorry.

s/Micael/Michael/