chromeos: Don't send empty power management policies.

chromeos: Don't send empty power management policies.

Update PowerPolicyController to not send an empty policy to
powerd when Chrome starts or exits. Empty policies were
originally sent to ensure the system wouldn't be stuck with
an old policy, but they also mean that powerd could briefly
revert to its default settings with undesireable results
when the system first boots or the user logs out (e.g. an
enterprise policy has disabled the lid-closed action, but
powerd reverts to its default settings and shuts down
automatically when the user logs out).

BUG=329930
TBR=benwells@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243566

[bartfab (slow), 2014-01-07 16:08:08]

lgtm

https://codereview.chromium.org/116983008/diff/100001/chromeos/dbus/fake_powe...
File chromeos/dbus/fake_power_manager_client.h (right):

https://codereview.chromium.org/116983008/diff/100001/chromeos/dbus/fake_powe...
chromeos/dbus/fake_power_manager_client.h:31: int set_policy_call_count() const
{
Nit: I know this method name derives from SetPolicy() but the result is rather
unfortunate: The method is a getter whose name starts with "set." Since this
getter is only used in a single place that verifies the method was never called,
maybe it is best to replace it with a bool was_set_policy_called()?

[Daniel Erat, 2014-01-07 17:25:47]

https://codereview.chromium.org/116983008/diff/100001/chromeos/dbus/fake_powe...
File chromeos/dbus/fake_power_manager_client.h (right):

https://codereview.chromium.org/116983008/diff/100001/chromeos/dbus/fake_powe...
chromeos/dbus/fake_power_manager_client.h:31: int set_policy_call_count() const
{
On 2014/01/07 16:08:08, bartfab wrote:
> Nit: I know this method name derives from SetPolicy() but the result is rather
> unfortunate: The method is a getter whose name starts with "set." Since this
> getter is only used in a single place that verifies the method was never
called,
> maybe it is best to replace it with a bool was_set_policy_called()?

Yeah, this bugged me too. :-/ I've renamed it to num_set_policy_calls() and have
renamed the other method to num_request_restart_calls() to match.

[Daniel Erat, 2014-01-07 17:31:06]

TBR Ben for method call renaming in chrome/browser/apps.

[commit-bot: I haz the power, 2014-01-07 17:31:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/116983008/240001

[commit-bot: I haz the power, 2014-01-07 20:14:33]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-07 20:34:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/116983008/240001

[commit-bot: I haz the power, 2014-01-08 00:22:33]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 00:29:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/116983008/240001

[commit-bot: I haz the power, 2014-01-08 04:51:55]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 14:11:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/116983008/240001

[commit-bot: I haz the power, 2014-01-08 15:36:11]

Change committed as 243566

[Noam Samuel, 2014-01-08 20:00:30]

A revert of this CL has been created in
https://codereview.chromium.org/129193002/ by noamsml@chromium.org.

The reason for reverting is: ChromeOS bot failures on x86/amd64.