chromeos: Don't send empty power management policies.

chrome/browser/chromeos/policy/power_policy_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 272 matching lines @@
 void PowerPolicyInSessionBrowserTest::SetUpOnMainThread() {
   PowerPolicyBrowserTestBase::SetUpOnMainThread();
 
   // Tell the DeviceSettingsService that there is no local owner.
   chromeos::DeviceSettingsService::Get()->SetUsername(std::string());
 }
 
 // Verifies that device policy is applied on the login screen.
 IN_PROC_BROWSER_TEST_F(PowerPolicyLoginScreenBrowserTest, SetDevicePolicy) {
   pm::PowerManagementPolicy power_management_policy =
-      power_manager_client_->get_policy();
+      power_manager_client_->policy();
   power_management_policy.mutable_ac_delays()->set_screen_dim_ms(5000);
   power_management_policy.mutable_ac_delays()->set_screen_off_ms(7000);
   power_management_policy.mutable_ac_delays()->set_idle_ms(9000);
   power_management_policy.mutable_battery_delays()->set_screen_dim_ms(1000);
   power_management_policy.mutable_battery_delays()->set_screen_off_ms(3000);
   power_management_policy.mutable_battery_delays()->set_idle_ms(4000);
   power_management_policy.set_ac_idle_action(
       pm::PowerManagementPolicy::DO_NOTHING);
   power_management_policy.set_battery_idle_action(
       pm::PowerManagementPolicy::DO_NOTHING);
   power_management_policy.set_lid_closed_action(
       pm::PowerManagementPolicy::DO_NOTHING);
   power_management_policy.set_user_activity_screen_dim_delay_factor(3.0);
 
   em::ChromeDeviceSettingsProto& proto(device_policy()->payload());
   proto.mutable_login_screen_power_management()->
       set_login_screen_power_management(kLoginScreenPowerManagementPolicy);
   StoreAndReloadDevicePolicyAndWaitForLoginProfileChange();
   EXPECT_EQ(GetDebugString(power_management_policy),
-            GetDebugString(power_manager_client_->get_policy()));
+            GetDebugString(power_manager_client_->policy()));
 }
 
 // Verifies that device policy is ignored during a session.
 IN_PROC_BROWSER_TEST_F(PowerPolicyInSessionBrowserTest, SetDevicePolicy) {
   pm::PowerManagementPolicy power_management_policy =
-      power_manager_client_->get_policy();
+      power_manager_client_->policy();
 
   em::ChromeDeviceSettingsProto& proto(device_policy()->payload());
   proto.mutable_login_screen_power_management()->
       set_login_screen_power_management(kLoginScreenPowerManagementPolicy);
   StoreAndReloadDevicePolicyAndWaitForLoginProfileChange();
   EXPECT_EQ(GetDebugString(power_management_policy),
-            GetDebugString(power_manager_client_->get_policy()));
+            GetDebugString(power_manager_client_->policy()));
 }
 
 // Verifies that user policy is applied during a session.
 IN_PROC_BROWSER_TEST_F(PowerPolicyInSessionBrowserTest, SetUserPolicy) {
   pm::PowerManagementPolicy power_management_policy =
-      power_manager_client_->get_policy();
+      power_manager_client_->policy();
   power_management_policy.mutable_ac_delays()->set_screen_dim_ms(5000);
   power_management_policy.mutable_ac_delays()->set_screen_lock_ms(6000);
   power_management_policy.mutable_ac_delays()->set_screen_off_ms(7000);
   power_management_policy.mutable_ac_delays()->set_idle_warning_ms(8000);
   power_management_policy.mutable_ac_delays()->set_idle_ms(9000);
   power_management_policy.mutable_battery_delays()->set_screen_dim_ms(1000);
   power_management_policy.mutable_battery_delays()->set_screen_lock_ms(2000);
   power_management_policy.mutable_battery_delays()->set_screen_off_ms(3000);
   power_management_policy.mutable_battery_delays()->set_idle_warning_ms(4000);
   power_management_policy.mutable_battery_delays()->set_idle_ms(5000);
@@ skipping 29 matching lines @@
       chromeos::PowerPolicyController::ACTION_STOP_SESSION);
   user_policy_.payload().mutable_lidcloseaction()->set_value(
       chromeos::PowerPolicyController::ACTION_STOP_SESSION);
   user_policy_.payload().mutable_presentationscreendimdelayscale()->set_value(
       300);
   user_policy_.payload().mutable_useractivityscreendimdelayscale()->set_value(
       300);
   user_policy_.payload().mutable_waitforinitialuseractivity()->set_value(true);
   StoreAndReloadUserPolicy();
   EXPECT_EQ(GetDebugString(power_management_policy),
-            GetDebugString(power_manager_client_->get_policy()));
+            GetDebugString(power_manager_client_->policy()));
 }
 
 // Verifies that screen wake locks can be enabled and disabled by extensions and
 // user policy during a session.
 IN_PROC_BROWSER_TEST_F(PowerPolicyInSessionBrowserTest, AllowScreenWakeLocks) {
   pm::PowerManagementPolicy baseline_policy =
-      power_manager_client_->get_policy();
+      power_manager_client_->policy();
 
   // Default settings should have delays.
   pm::PowerManagementPolicy power_management_policy = baseline_policy;
   EXPECT_NE(0, baseline_policy.ac_delays().screen_dim_ms());
   EXPECT_NE(0, baseline_policy.ac_delays().screen_off_ms());
   EXPECT_NE(0, baseline_policy.battery_delays().screen_dim_ms());
   EXPECT_NE(0, baseline_policy.battery_delays().screen_off_ms());
 
   // Pretend an extension grabs a screen wake lock.
   const char kExtensionId[] = "abcdefghijklmnopabcdefghijlkmnop";
   extensions::PowerApiManager::GetInstance()->AddRequest(
       kExtensionId, extensions::api::power::LEVEL_DISPLAY);
   base::RunLoop().RunUntilIdle();
 
   // Check that the lock is in effect (ignoring ac_idle_action,
   // battery_idle_action and reason).
   pm::PowerManagementPolicy policy = baseline_policy;
   policy.mutable_ac_delays()->set_screen_dim_ms(0);
   policy.mutable_ac_delays()->set_screen_off_ms(0);
   policy.mutable_battery_delays()->set_screen_dim_ms(0);
   policy.mutable_battery_delays()->set_screen_off_ms(0);
   policy.set_ac_idle_action(
-      power_manager_client_->get_policy().ac_idle_action());
+      power_manager_client_->policy().ac_idle_action());
   policy.set_battery_idle_action(
-      power_manager_client_->get_policy().battery_idle_action());
-  policy.set_reason(power_manager_client_->get_policy().reason());
+      power_manager_client_->policy().battery_idle_action());
+  policy.set_reason(power_manager_client_->policy().reason());
   EXPECT_EQ(GetDebugString(policy),
-            GetDebugString(power_manager_client_->get_policy()));
+            GetDebugString(power_manager_client_->policy()));
 
   // Engage the user policy and verify that the defaults take effect again.
   user_policy_.payload().mutable_allowscreenwakelocks()->set_value(false);
   StoreAndReloadUserPolicy();
   policy = baseline_policy;
-  policy.set_ac_idle_action(
-      power_manager_client_->get_policy().ac_idle_action());
+  policy.set_ac_idle_action(power_manager_client_->policy().ac_idle_action());
   policy.set_battery_idle_action(
-      power_manager_client_->get_policy().battery_idle_action());
-  policy.set_reason(power_manager_client_->get_policy().reason());
+      power_manager_client_->policy().battery_idle_action());
+  policy.set_reason(power_manager_client_->policy().reason());
   EXPECT_EQ(GetDebugString(policy),
-            GetDebugString(power_manager_client_->get_policy()));
+            GetDebugString(power_manager_client_->policy()));
 }
 
 }  // namespace policy