Source/bindings/v8/ScriptDebugServer.cpp - Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptDebugServer.cpp

diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp

index 637e5683e122cac8b34785558744c58b7807bcfd..1e109467cf89c5b628ed5f513610821851b75f25 100644

--- a/Source/bindings/v8/ScriptDebugServer.cpp

+++ b/Source/bindings/v8/ScriptDebugServer.cpp

@@ -543,7 +543,7 @@ v8::Handle<v8::Value> ScriptDebugServer::setFunctionVariableValue(v8::Handle<v8:

{

v8::Local<v8::Context> debuggerContext = v8::Debug::GetDebugContext();

if (m_debuggerScript.isEmpty())

- return m_isolate->ThrowException(v8::String::NewFromUtf8(m_isolate, "Debugging is not enabled."));

+ return m_isolate->ThrowException(v8AtomicString(m_isolate, "Debugging is not enabled."));

v8::Handle<v8::Value> argv[] = {

functionValue,