Source/bindings/v8/NPV8Object.cpp - Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/NPV8Object.cpp

Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/NPV8Object.cpp

diff --git a/Source/bindings/v8/NPV8Object.cpp b/Source/bindings/v8/NPV8Object.cpp

index 64463bae8363c19cd9380d0a6ccca8dd1319b25f..99e5e0c2cc3957f9025d0bf3976b4d59e5e12aea 100644

--- a/Source/bindings/v8/NPV8Object.cpp

+++ b/Source/bindings/v8/NPV8Object.cpp

@@ -542,7 +542,7 @@ bool _NPN_Enumerate(NPP npp, NPObject* npObject, NPIdentifier** identifier, uint

" }"

" return props;"

"});";

- v8::Handle<v8::String> source = v8::String::NewFromUtf8(isolate, enumeratorCode);

+ v8::Handle<v8::String> source = v8AtomicString(isolate, enumeratorCode);

v8::Handle<v8::Value> result = V8ScriptRunner::compileAndRunInternalScript(source, context->GetIsolate());

ASSERT(!result.IsEmpty());

ASSERT(result->IsFunction());