Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: Source/bindings/v8/IDBBindingUtilitiesTest.cpp

Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/IDBBindingUtilitiesTest.cpp
diff --git a/Source/bindings/v8/IDBBindingUtilitiesTest.cpp b/Source/bindings/v8/IDBBindingUtilitiesTest.cpp
index 0f6ff63ee328d4e448a53f3d7c44aed4dcb907a1..e90569b020c71e6b32dfe27fc19616394439f162 100644
--- a/Source/bindings/v8/IDBBindingUtilitiesTest.cpp
+++ b/Source/bindings/v8/IDBBindingUtilitiesTest.cpp
@@ -106,7 +106,7 @@ private:
TEST_F(IDBKeyFromValueAndKeyPathTest, TopLevelPropertyStringValue)
{
v8::Local<v8::Object> object = v8::Object::New();
- object->Set(v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "foo"), v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "zoo"));
+ object->Set(v8AtomicString(v8::Isolate::GetCurrent(), "foo"), v8AtomicString(v8::Isolate::GetCurrent(), "zoo"));
ScriptValue scriptValue(object, v8::Isolate::GetCurrent());
@@ -117,7 +117,7 @@ TEST_F(IDBKeyFromValueAndKeyPathTest, TopLevelPropertyStringValue)
TEST_F(IDBKeyFromValueAndKeyPathTest, TopLevelPropertyNumberValue)
{
v8::Local<v8::Object> object = v8::Object::New();
- object->Set(v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "foo"), v8::Number::New(456));
+ object->Set(v8AtomicString(v8::Isolate::GetCurrent(), "foo"), v8::Number::New(456));
ScriptValue scriptValue(object, v8::Isolate::GetCurrent());
@@ -129,8 +129,8 @@ TEST_F(IDBKeyFromValueAndKeyPathTest, SubProperty)
{
v8::Local<v8::Object> object = v8::Object::New();
v8::Local<v8::Object> subProperty = v8::Object::New();
- subProperty->Set(v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "bar"), v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "zee"));
- object->Set(v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "foo"), subProperty);
+ subProperty->Set(v8AtomicString(v8::Isolate::GetCurrent(), "bar"), v8AtomicString(v8::Isolate::GetCurrent(), "zee"));
+ object->Set(v8AtomicString(v8::Isolate::GetCurrent(), "foo"), subProperty);
ScriptValue scriptValue(object, v8::Isolate::GetCurrent());
@@ -144,7 +144,7 @@ class InjectIDBKeyTest : public IDBKeyFromValueAndKeyPathTest {
TEST_F(InjectIDBKeyTest, TopLevelPropertyStringValue)
{
v8::Local<v8::Object> object = v8::Object::New();
- object->Set(v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "foo"), v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "zoo"));
+ object->Set(v8AtomicString(v8::Isolate::GetCurrent(), "foo"), v8AtomicString(v8::Isolate::GetCurrent(), "zoo"));
ScriptValue foozoo(object, v8::Isolate::GetCurrent());
checkInjection(IDBKey::createString("myNewKey"), foozoo, "bar");
@@ -157,8 +157,8 @@ TEST_F(InjectIDBKeyTest, SubProperty)
{
v8::Local<v8::Object> object = v8::Object::New();
v8::Local<v8::Object> subProperty = v8::Object::New();
- subProperty->Set(v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "bar"), v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "zee"));
- object->Set(v8::String::NewFromUtf8(v8::Isolate::GetCurrent(), "foo"), subProperty);
+ subProperty->Set(v8AtomicString(v8::Isolate::GetCurrent(), "bar"), v8AtomicString(v8::Isolate::GetCurrent(), "zee"));
+ object->Set(v8AtomicString(v8::Isolate::GetCurrent(), "foo"), subProperty);
ScriptValue scriptObject(object, v8::Isolate::GetCurrent());
checkInjection(IDBKey::createString("myNewKey"), scriptObject, "foo.baz");

Powered by Google App Engine
This is Rietveld 408576698