Improve line info accuracy in debugging

runtime/vm/debugger_api_impl_test.cc

Index: runtime/vm/debugger_api_impl_test.cc
===================================================================
--- runtime/vm/debugger_api_impl_test.cc	(revision 16535)
+++ runtime/vm/debugger_api_impl_test.cc	(working copy)
@@ -971,9 +971,7 @@
   const String& script_url = String::Handle(String::New(TestCase::url()));
   Function& func = Function::Handle();
 
-  // TODO(hausner): Looking up functions from source and line number
-  // needs to be refined. We currently dont find "main" on line 7.
-  for (int line = 8; line <= 9; line++) {
+  for (int line = 7; line <= 9; line++) {
     func = test_lib.LookupFunctionInSource(script_url, line);
     EXPECT(!func.IsNull());
     EXPECT_STREQ("main", String::Handle(func.name()).ToCString());
@@ -984,7 +982,8 @@
   EXPECT_STREQ("foo", String::Handle(func.name()).ToCString());
 
   func = test_lib.LookupFunctionInSource(script_url, 1);
-  EXPECT(func.IsNull());
+  EXPECT(!func.IsNull());

[Ivan Posva, 2012/12/28 17:53:49]

Please explain in a comment why you find the constructor for A.

[hausner, 2013/01/07 23:24:31]

Done.

+  EXPECT_STREQ("A.", String::Handle(func.name()).ToCString());
   func = test_lib.LookupFunctionInSource(script_url, 6);
   EXPECT(func.IsNull());
   func = test_lib.LookupFunctionInSource(script_url, 10);