Improve line info accuracy in debugging

runtime/vm/debugger_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 #include "platform/assert.h"
 #include "vm/dart_api_impl.h"
 #include "vm/thread.h"
 #include "vm/unit_test.h"
 
@@ skipping 953 matching lines @@
   /*9*/  "}                         \n"
   /*10*/ "                          \n";
 
   LoadScript(kScriptChars);
 
   const Library& test_lib =
       Library::CheckedHandle(Api::UnwrapHandle(script_lib));
   const String& script_url = String::Handle(String::New(TestCase::url()));
   Function& func = Function::Handle();
 
-  // TODO(hausner): Looking up functions from source and line number
-  // needs to be refined. We currently dont find "main" on line 7.
-  for (int line = 8; line <= 9; line++) {
+  for (int line = 7; line <= 9; line++) {
     func = test_lib.LookupFunctionInSource(script_url, line);
     EXPECT(!func.IsNull());
     EXPECT_STREQ("main", String::Handle(func.name()).ToCString());
   }
 
   func = test_lib.LookupFunctionInSource(script_url, 3);

[Ivan Posva, 2012/12/28 17:53:49]

Shouldn't this be lines 2,3 and 4 now?

[hausner, 2013/01/07 23:24:31]

Done.

   EXPECT(!func.IsNull());
   EXPECT_STREQ("foo", String::Handle(func.name()).ToCString());
 
   func = test_lib.LookupFunctionInSource(script_url, 1);
-  EXPECT(func.IsNull());
+  EXPECT(!func.IsNull());

[Ivan Posva, 2012/12/28 17:53:49]

Please explain in a comment why you find the constructor for A.

[hausner, 2013/01/07 23:24:31]

Done.

+  EXPECT_STREQ("A.", String::Handle(func.name()).ToCString());
   func = test_lib.LookupFunctionInSource(script_url, 6);
   EXPECT(func.IsNull());
   func = test_lib.LookupFunctionInSource(script_url, 10);
   EXPECT(func.IsNull());
 
   Dart_Handle libs = Dart_GetLibraryURLs();
   EXPECT(Dart_IsList(libs));
   intptr_t num_libs;
   Dart_ListLength(libs, &num_libs);
   EXPECT(num_libs > 0);
@@ skipping 222 matching lines @@
     while (interrupt_isolate_id != ILLEGAL_ISOLATE_ID) {
       ml.Wait();
     }
   }
   EXPECT(interrupt_isolate_id == ILLEGAL_ISOLATE_ID);
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart