Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1169533003: First patch for Mips subzero compiler (Closed)

Created:
5 years, 6 months ago by reed.kotler
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1029 lines, -40 lines) Patch
M Makefile.standalone View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceClFlags.cpp View 1 chunk +4 lines, -1 line 0 comments Download
A src/IceInstMIPS32.h View 1 chunk +28 lines, -0 lines 0 comments Download
A src/IceInstMIPS32.def View 1 chunk +81 lines, -0 lines 0 comments Download
A + src/IceRegistersMIPS32.h View 5 chunks +11 lines, -11 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
A src/IceTargetLoweringMIPS32.h View 1 chunk +149 lines, -0 lines 0 comments Download
A src/IceTargetLoweringMIPS32.cpp View 1 chunk +705 lines, -0 lines 0 comments Download
A src/IceTargetLoweringMIPS32.def View 1 chunk +20 lines, -0 lines 0 comments Download
M src/IceTypes.def View 1 chunk +7 lines, -6 lines 0 comments Download
A + src/assembler_mips32.h View 3 chunks +21 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
reed.kotler
Move the issue here so that it's under the proper email.
5 years, 6 months ago (2015-06-06 22:09:26 UTC) #2
reed.kotler
On 2015/06/06 22:09:26, reed.kotler wrote: > Move the issue here so that it's under the ...
5 years, 6 months ago (2015-06-09 02:20:41 UTC) #3
reed.kotler
On 2015/06/09 02:20:41, reed.kotler wrote: > On 2015/06/06 22:09:26, reed.kotler wrote: > > Move the ...
5 years, 6 months ago (2015-06-09 16:24:46 UTC) #4
Jim Stichnoth
Committed patchset #1 (id:1) manually as 6da4cef77cdfbd8d42ee08171d550cc6414d06ab (presubmit successful).
5 years, 6 months ago (2015-06-11 20:26:37 UTC) #5
Jim Stichnoth
5 years, 6 months ago (2015-06-11 20:30:38 UTC) #6
Message was sent while issue was closed.
I landed this patch.  Unfortunately, since I waited too long, there had been
some refactoring in Subzero that required some manual changes to the patch.

It would be good to rename assembler_mips32.h ==> IceAssemblerMIPS32.h in the
near future.

Powered by Google App Engine
This is Rietveld 408576698