Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1169493003: Turn test runner library into an actual component (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-screen-orientation_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn test runner library into an actual component The main motivation is to enforce correct layering and dependencies BUG=478250 R=jam@chromium.org Committed: https://crrev.com/746754c581f8a0d0b6d1b9ec2256077391eed1b2 Cr-Commit-Position: refs/heads/master@{#333065}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -36 lines) Patch
M components/test_runner/BUILD.gn View 1 3 chunks +8 lines, -2 lines 0 comments Download
M components/test_runner/app_banner_client.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M components/test_runner/gamepad_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/test_runner/mock_screen_orientation_client.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M components/test_runner/test_common.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/test_runner/test_preferences.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/test_runner/test_runner.h View 3 chunks +2 lines, -1 line 0 comments Download
M components/test_runner/test_runner.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 3 chunks +14 lines, -8 lines 0 comments Download
A components/test_runner/test_runner_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M components/test_runner/web_frame_test_proxy.h View 3 chunks +12 lines, -11 lines 0 comments Download
M components/test_runner/web_test_interfaces.h View 3 chunks +4 lines, -1 line 0 comments Download
M components/test_runner/web_test_interfaces.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 3 chunks +5 lines, -1 line 0 comments Download
M components/test_runner/web_test_proxy.cc View 3 chunks +11 lines, -1 line 0 comments Download
M components/test_runner/web_test_runner.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
ptal
5 years, 6 months ago (2015-06-05 12:01:19 UTC) #1
jam
lgtm I can't tell from the cl description what is the reason for doing this ...
5 years, 6 months ago (2015-06-05 15:49:47 UTC) #2
jochen (gone - plz use gerrit)
it helped to get the dependencies right, for example
5 years, 6 months ago (2015-06-05 16:04:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169493003/20001
5 years, 6 months ago (2015-06-05 16:05:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 16:40:49 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 16:41:40 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/746754c581f8a0d0b6d1b9ec2256077391eed1b2
Cr-Commit-Position: refs/heads/master@{#333065}

Powered by Google App Engine
This is Rietveld 408576698