Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: components/test_runner/test_runner.gyp

Issue 1169493003: Turn test runner library into an actual component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/test_runner.cc ('k') | components/test_runner/test_runner_export.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_runner.gyp
diff --git a/components/test_runner/test_runner.gyp b/components/test_runner/test_runner.gyp
index 4b5694bc0e7a39e892ef34604e9900d2e126488d..0a06f74647547c9282c53e36ac58fc94814ef49f 100644
--- a/components/test_runner/test_runner.gyp
+++ b/components/test_runner/test_runner.gyp
@@ -3,25 +3,33 @@
# found in the LICENSE file.
{
+ 'variables': {
+ # This turns on e.g. the filename-based detection of which
+ # platforms to include source files on (e.g. files ending in
+ # _mac.h or _mac.cc are only compiled on MacOSX).
+ 'chromium_code': 1,
+ },
'targets': [
{
# GN version: //components/test_runner:test_runner
'target_name': 'test_runner',
- 'type': 'static_library',
- 'variables': {
- 'chromium_code': 1,
- },
+ 'type': '<(component)',
+ 'defines': [
+ 'TEST_RUNNER_IMPLEMENTATION',
+ ],
'dependencies': [
'resources',
'../../base/base.gyp:base',
- '../../base/base.gyp:base_static',
'../../cc/cc.gyp:cc',
'../../gin/gin.gyp:gin',
+ '../../gpu/gpu.gyp:gpu',
'../../skia/skia.gyp:skia',
'../../third_party/WebKit/public/blink.gyp:blink',
+ '../../ui/events/events.gyp:dom_keycode_converter',
'../../ui/events/events.gyp:events_base',
'../../ui/gfx/gfx.gyp:gfx',
'../../ui/gfx/gfx.gyp:gfx_geometry',
+ '../../url/url.gyp:url_lib',
'../../v8/tools/gyp/v8.gyp:v8',
],
'include_dirs': [
@@ -77,6 +85,7 @@
'test_plugin.h',
'test_runner.cc',
'test_runner.h',
+ 'test_runner_export.h',
'test_preferences.cc',
'test_preferences.h',
'text_input_controller.cc',
@@ -173,9 +182,6 @@
# GN version: //components/test_runner:layout_test_helper
'target_name': 'layout_test_helper',
'type': 'executable',
- 'variables': {
- 'chromium_code': 1,
- },
'sources': [
'helper/layout_test_helper_mac.mm',
'helper/layout_test_helper_win.cc',
« no previous file with comments | « components/test_runner/test_runner.cc ('k') | components/test_runner/test_runner_export.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698