Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1169453003: Revert of Add SIMD 128 alignment support to Heap. (Closed)

Created:
5 years, 6 months ago by bbudge
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add SIMD 128 alignment support to Heap. (patchset #3 id:40001 of https://codereview.chromium.org/1159453004/) Reason for revert: Breaks Linux - arm64 - sim - MSAN TBR=jochen Original issue's description: > Add SIMD 128 alignment support to Heap. > Adds SIMD 128 alignment sizes and masks. > Adds support in Heap for SIMD alignments and fills. > Reworks cctest so that each test independently aligns its allocation address, rather than depending on the previous tests ending state. Adds test cases for SIMD. > > LOG=N > BUG=v8:4124 TBR=hpayer@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Committed: https://crrev.com/6a6388f07d3926587122a462a746f1a450858864 Cr-Commit-Position: refs/heads/master@{#28768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -204 lines) Patch
M src/globals.h View 3 chunks +1 line, -12 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +76 lines, -186 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bbudge
Created Revert of Add SIMD 128 alignment support to Heap.
5 years, 6 months ago (2015-06-02 21:08:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169453003/1
5 years, 6 months ago (2015-06-02 21:08:25 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-02 21:08:29 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-02 21:12:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169453003/1
5 years, 6 months ago (2015-06-02 21:12:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 21:13:21 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 21:16:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a6388f07d3926587122a462a746f1a450858864
Cr-Commit-Position: refs/heads/master@{#28768}

Powered by Google App Engine
This is Rietveld 408576698