Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1159453004: Add SIMD 128 alignment support to Heap. (Closed)

Created:
5 years, 7 months ago by bbudge
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add SIMD 128 alignment support to Heap. Adds SIMD 128 alignment sizes and masks. Adds support in Heap for SIMD alignments and fills. Reworks cctest so that each test independently aligns its allocation address, rather than depending on the previous tests ending state. Adds test cases for SIMD. LOG=N BUG=v8:4124 Committed: https://crrev.com/4347d56a6919ae06a70e4a4a8b2f1179cf47bc7e Cr-Commit-Position: refs/heads/master@{#28767} Committed: https://crrev.com/a18a94ef364b66dd9329db0d32c415503cfa3616 Cr-Commit-Position: refs/heads/master@{#28771}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : All tests. #

Patch Set 4 : Only mark aligned object memory as MSAN uninitialized. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -76 lines) Patch
M src/globals.h View 1 2 3 3 chunks +12 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 chunks +185 lines, -75 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
bbudge
5 years, 6 months ago (2015-05-29 22:09:32 UTC) #2
bbudge
ping
5 years, 6 months ago (2015-06-02 12:02:35 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-02 18:30:02 UTC) #5
Hannes Payer (out of office)
On 2015/06/02 18:30:02, jochen wrote: > lgtm Lgtm
5 years, 6 months ago (2015-06-02 18:41:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159453004/40001
5 years, 6 months ago (2015-06-02 19:23:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159453004/40001
5 years, 6 months ago (2015-06-02 20:38:29 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-02 20:40:21 UTC) #12
bbudge
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1169453003/ by bbudge@chromium.org. ...
5 years, 6 months ago (2015-06-02 21:08:07 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4347d56a6919ae06a70e4a4a8b2f1179cf47bc7e Cr-Commit-Position: refs/heads/master@{#28767}
5 years, 6 months ago (2015-06-02 21:15:58 UTC) #14
bbudge
MSAN was marking the whole allocation as uninitialized, which caused the filler objects to trigger ...
5 years, 6 months ago (2015-06-02 22:22:36 UTC) #15
bbudge
On 2015/06/02 22:22:36, bbudge wrote: > MSAN was marking the whole allocation as uninitialized, which ...
5 years, 6 months ago (2015-06-02 22:38:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159453004/60001
5 years, 6 months ago (2015-06-02 22:40:45 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-02 22:56:09 UTC) #20
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 22:56:22 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a18a94ef364b66dd9329db0d32c415503cfa3616
Cr-Commit-Position: refs/heads/master@{#28771}

Powered by Google App Engine
This is Rietveld 408576698