Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2098)

Unified Diff: content/renderer/pepper/pepper_webplugin_impl.cc

Issue 1169263003: Change return type of PrintPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/pepper_webplugin_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/pepper_webplugin_impl.cc
diff --git a/content/renderer/pepper/pepper_webplugin_impl.cc b/content/renderer/pepper/pepper_webplugin_impl.cc
index 914d3950c64fa146fc53b5df61f30aca5307da1b..b330f32513136cbb3911c7d07c3abd257ca2ec33 100644
--- a/content/renderer/pepper/pepper_webplugin_impl.cc
+++ b/content/renderer/pepper/pepper_webplugin_impl.cc
@@ -275,11 +275,11 @@ void PepperWebPluginImpl::printPage(int page_number, blink::WebCanvas* canvas,
return instance_->PrintPage(page_number, canvas);
}
-bool PepperWebPluginImpl::printPage(int page_number, blink::WebCanvas* canvas) {
- instance_->PrintPage(page_number, canvas);
- return true;
+void PepperWebPluginImpl::printPage(int page_number, blink::WebCanvas* canvas) {
+ return instance_->PrintPage(page_number, canvas);
raymes 2015/06/12 00:01:52 This "return" can be removed right?
Habib Virji 2015/06/12 13:29:18 That's true removed. Also below printEnd which doe
}
+
piman 2015/06/11 22:45:14 nit: please remove redundant empty line
Habib Virji 2015/06/12 13:29:18 Thanks. Done.
void PepperWebPluginImpl::printEnd() { return instance_->PrintEnd(); }
bool PepperWebPluginImpl::getPrintPresetOptionsFromDocument(
« no previous file with comments | « content/renderer/pepper/pepper_webplugin_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698