Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: content/renderer/pepper/pepper_webplugin_impl.cc

Issue 1169263003: Change return type of PrintPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/pepper/pepper_webplugin_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/pepper/pepper_webplugin_impl.h" 5 #include "content/renderer/pepper/pepper_webplugin_impl.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "base/debug/crash_logging.h" 9 #include "base/debug/crash_logging.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 268
269 int PepperWebPluginImpl::printBegin(const WebPrintParams& print_params) { 269 int PepperWebPluginImpl::printBegin(const WebPrintParams& print_params) {
270 return instance_->PrintBegin(print_params); 270 return instance_->PrintBegin(print_params);
271 } 271 }
272 272
273 void PepperWebPluginImpl::printPage(int page_number, blink::WebCanvas* canvas, 273 void PepperWebPluginImpl::printPage(int page_number, blink::WebCanvas* canvas,
274 bool unused) { 274 bool unused) {
275 return instance_->PrintPage(page_number, canvas); 275 return instance_->PrintPage(page_number, canvas);
276 } 276 }
277 277
278 bool PepperWebPluginImpl::printPage(int page_number, blink::WebCanvas* canvas) { 278 void PepperWebPluginImpl::printPage(int page_number, blink::WebCanvas* canvas) {
279 instance_->PrintPage(page_number, canvas); 279 return instance_->PrintPage(page_number, canvas);
raymes 2015/06/12 00:01:52 This "return" can be removed right?
Habib Virji 2015/06/12 13:29:18 That's true removed. Also below printEnd which doe
280 return true;
281 } 280 }
282 281
282
piman 2015/06/11 22:45:14 nit: please remove redundant empty line
Habib Virji 2015/06/12 13:29:18 Thanks. Done.
283 void PepperWebPluginImpl::printEnd() { return instance_->PrintEnd(); } 283 void PepperWebPluginImpl::printEnd() { return instance_->PrintEnd(); }
284 284
285 bool PepperWebPluginImpl::getPrintPresetOptionsFromDocument( 285 bool PepperWebPluginImpl::getPrintPresetOptionsFromDocument(
286 blink::WebPrintPresetOptions* preset_options) { 286 blink::WebPrintPresetOptions* preset_options) {
287 return instance_->GetPrintPresetOptionsFromDocument(preset_options); 287 return instance_->GetPrintPresetOptionsFromDocument(preset_options);
288 } 288 }
289 289
290 bool PepperWebPluginImpl::canRotateView() { return instance_->CanRotateView(); } 290 bool PepperWebPluginImpl::canRotateView() { return instance_->CanRotateView(); }
291 291
292 void PepperWebPluginImpl::rotateView(RotationType type) { 292 void PepperWebPluginImpl::rotateView(RotationType type) {
293 instance_->RotateView(type); 293 instance_->RotateView(type);
294 } 294 }
295 295
296 bool PepperWebPluginImpl::isPlaceholder() { return false; } 296 bool PepperWebPluginImpl::isPlaceholder() { return false; }
297 297
298 } // namespace content 298 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/pepper/pepper_webplugin_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698