Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1169263003: Change return type of PrintPage (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
raymes, piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change return type of PrintPage Patchset #3 to land chromium side changes for changing return type of the PrintPage. BUG=496765 R=piman@chromium.org, raymes Committed: https://crrev.com/910c326be112c84f9df0159da7cdcde38a0fbc75 Cr-Commit-Position: refs/heads/master@{#334573}

Patch Set 1 #

Total comments: 4

Patch Set 2 : bool printPage removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M content/renderer/pepper/pepper_webplugin_impl.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169263003/1
5 years, 6 months ago (2015-06-11 14:30:00 UTC) #2
Habib Virji
This change will involve a total set of five patches. This is patch #3 from ...
5 years, 6 months ago (2015-06-11 14:30:51 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/46684)
5 years, 6 months ago (2015-06-11 14:40:08 UTC) #5
piman
lgtm https://codereview.chromium.org/1169263003/diff/1/content/renderer/pepper/pepper_webplugin_impl.cc File content/renderer/pepper/pepper_webplugin_impl.cc (right): https://codereview.chromium.org/1169263003/diff/1/content/renderer/pepper/pepper_webplugin_impl.cc#newcode282 content/renderer/pepper/pepper_webplugin_impl.cc:282: nit: please remove redundant empty line
5 years, 6 months ago (2015-06-11 22:45:15 UTC) #6
raymes
https://codereview.chromium.org/1169263003/diff/1/content/renderer/pepper/pepper_webplugin_impl.cc File content/renderer/pepper/pepper_webplugin_impl.cc (right): https://codereview.chromium.org/1169263003/diff/1/content/renderer/pepper/pepper_webplugin_impl.cc#newcode279 content/renderer/pepper/pepper_webplugin_impl.cc:279: return instance_->PrintPage(page_number, canvas); This "return" can be removed right?
5 years, 6 months ago (2015-06-12 00:01:52 UTC) #7
Habib Virji
https://codereview.chromium.org/1169263003/diff/1/content/renderer/pepper/pepper_webplugin_impl.cc File content/renderer/pepper/pepper_webplugin_impl.cc (right): https://codereview.chromium.org/1169263003/diff/1/content/renderer/pepper/pepper_webplugin_impl.cc#newcode279 content/renderer/pepper/pepper_webplugin_impl.cc:279: return instance_->PrintPage(page_number, canvas); That's true removed. Also below printEnd ...
5 years, 6 months ago (2015-06-12 13:29:18 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169263003/20001
5 years, 6 months ago (2015-06-12 13:29:42 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-12 14:13:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169263003/20001
5 years, 6 months ago (2015-06-15 12:38:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/67878)
5 years, 6 months ago (2015-06-15 14:06:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169263003/20001
5 years, 6 months ago (2015-06-16 09:21:36 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 09:25:38 UTC) #20
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 09:26:41 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/910c326be112c84f9df0159da7cdcde38a0fbc75
Cr-Commit-Position: refs/heads/master@{#334573}

Powered by Google App Engine
This is Rietveld 408576698