[Extensions] Clean up the handling of ExtensionHostMsg_Request

extensions/browser/guest_view/web_view/web_view_guest.cc

Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index 71dac535b1e7be056b944d5f436c7cf91f52fce5..739847f5c6c39453983e239142163563fe233406 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -336,7 +336,8 @@ void WebViewGuest::DidInitialize(const base::DictionaryValue& create_params) {
 
   if (web_view_guest_delegate_)
     web_view_guest_delegate_->OnDidInitialize();
-  AttachWebViewHelpers(web_contents());
+  ExtensionsAPIClient::Get()->AttachWebContentsHelpers(web_contents());

[Fady Samuel, 2015/06/10 20:51:18]

Does this mean all extensions will get routed to a function dispatcher? Does
that mean arbitrary extension APIs will work inside a webview? I worry this
breaks things?

[Devlin, 2015/06/10 20:59:20]

Not really.  ExtensionWebContentsObserver (and ExtensionFunctionDispatcher, etc)
don't inherently allow for a web contents to use extension APIs.  That's handled
primarily by the exposure of the bindings to different javascript contexts,
which is all handled on the renderer side.  All this should do is wire up
relevant web contents helpers - which could be useful if, for instance, we
happen to embed an extension page in a web view.

+  web_view_permission_helper_.reset(new WebViewPermissionHelper(this));
 
   rules_registry_id_ = GetOrGenerateRulesRegistryID(
       owner_web_contents()->GetRenderProcessHost()->GetID(),
@@ -350,12 +351,6 @@ void WebViewGuest::DidInitialize(const base::DictionaryValue& create_params) {
   ApplyAttributes(create_params);
 }
 
-void WebViewGuest::AttachWebViewHelpers(WebContents* contents) {
-  if (web_view_guest_delegate_)
-    web_view_guest_delegate_->OnAttachWebViewHelpers(contents);
-  web_view_permission_helper_.reset(new WebViewPermissionHelper(this));
-}
-
 void WebViewGuest::ClearDataInternal(base::Time remove_since,
                                      uint32 removal_mask,
                                      const base::Closure& callback) {