[Extensions] Clean up the handling of ExtensionHostMsg_Request

extensions/browser/guest_view/web_view/web_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/browsing_data/storage_partition_http_cache_data_remover.h"
@@ skipping 318 matching lines @@
   notification_registrar_.Add(this,
                               content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
                               content::Source<WebContents>(web_contents()));
 
   notification_registrar_.Add(this,
                               content::NOTIFICATION_RESOURCE_RECEIVED_REDIRECT,
                               content::Source<WebContents>(web_contents()));
 
   if (web_view_guest_delegate_)
     web_view_guest_delegate_->OnDidInitialize();
-  AttachWebViewHelpers(web_contents());
+  ExtensionsAPIClient::Get()->AttachWebContentsHelpers(web_contents());

[Fady Samuel, 2015/06/10 20:51:18]

Does this mean all extensions will get routed to a function dispatcher? Does
that mean arbitrary extension APIs will work inside a webview? I worry this
breaks things?

[Devlin, 2015/06/10 20:59:20]

Not really.  ExtensionWebContentsObserver (and ExtensionFunctionDispatcher, etc)
don't inherently allow for a web contents to use extension APIs.  That's handled
primarily by the exposure of the bindings to different javascript contexts,
which is all handled on the renderer side.  All this should do is wire up
relevant web contents helpers - which could be useful if, for instance, we
happen to embed an extension page in a web view.

+  web_view_permission_helper_.reset(new WebViewPermissionHelper(this));
 
   rules_registry_id_ = GetOrGenerateRulesRegistryID(
       owner_web_contents()->GetRenderProcessHost()->GetID(),
       view_instance_id());
 
   // We must install the mapping from guests to WebViews prior to resuming
   // suspended resource loads so that the WebRequest API will catch resource
   // requests.
   PushWebViewStateToIOThread();
 
   ApplyAttributes(create_params);
 }
 
-void WebViewGuest::AttachWebViewHelpers(WebContents* contents) {
-  if (web_view_guest_delegate_)
-    web_view_guest_delegate_->OnAttachWebViewHelpers(contents);
-  web_view_permission_helper_.reset(new WebViewPermissionHelper(this));
-}
-
 void WebViewGuest::ClearDataInternal(base::Time remove_since,
                                      uint32 removal_mask,
                                      const base::Closure& callback) {
   uint32 storage_partition_removal_mask =
       GetStoragePartitionRemovalMask(removal_mask);
   if (!storage_partition_removal_mask) {
     callback.Run();
     return;
   }
   content::StoragePartition* partition =
@@ skipping 1072 matching lines @@
     scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
     DispatchEventToView(
         new GuestViewEvent(webview::kEventExitFullscreen, args.Pass()));
   }
   // Since we changed fullscreen state, sending a Resize message ensures that
   // renderer/ sees the change.
   web_contents()->GetRenderViewHost()->WasResized();
 }
 
 }  // namespace extensions