extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h - Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc ('K') | « extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

index b9a6fe3533adf9d3719e736e029e36693c7d304c..e065104dbecbcf6bcef953cf389a30b468a7d82b 100644

--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

@@ -19,12 +19,9 @@ class MimeHandlerViewGuest;

// A delegate class of MimeHandlerViewGuest that are not a part of chrome.

class MimeHandlerViewGuestDelegate {

public:

- explicit MimeHandlerViewGuestDelegate(MimeHandlerViewGuest* guest) {}

+ MimeHandlerViewGuestDelegate() {}

virtual ~MimeHandlerViewGuestDelegate() {}

- // Attaches helpers upon initializing the WebContents.

- virtual void AttachHelpers() {}

// Handles context menu, or returns false if unhandled.

virtual bool HandleContextMenu(content::WebContents* web_contents,

const content::ContextMenuParams& params);