chrome/browser/extensions/tab_helper.h - Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/tab_helper.h

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/chrome_extension_function_details.cc ('K') | « chrome/browser/extensions/extension_function_test_utils.cc ('k') | chrome/browser/extensions/tab_helper.cc » ('j') | chrome/browser/extensions/tab_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/tab_helper.h

diff --git a/chrome/browser/extensions/tab_helper.h b/chrome/browser/extensions/tab_helper.h

index 5564f914d169e2f7275f589f45e7666aa1cf8269..8a0e52c8d7b56a28a0925baadc5cea14918b2e0d 100644

--- a/chrome/browser/extensions/tab_helper.h

+++ b/chrome/browser/extensions/tab_helper.h

@@ -167,7 +167,6 @@ class TabHelper : public content::WebContentsObserver,

void OnGetAppInstallState(const GURL& requestor_url,

int return_route_id,

int callback_id);

- void OnRequest(const ExtensionHostMsg_Request_Params& params);

void OnContentScriptsExecuting(

const ScriptExecutionObserver::ExecutingScriptsMap& extension_ids,

const GURL& on_url);

@@ -226,9 +225,6 @@ class TabHelper : public content::WebContentsObserver,

// non-extension apps.

SkBitmap extension_app_icon_;

- // Process any extension messages coming from the tab.

- extensions::ExtensionFunctionDispatcher extension_function_dispatcher_;

// Cached web app info data.

WebApplicationInfo web_app_info_;