chrome/browser/extensions/api/chrome_extensions_api_client.h - Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/chrome_extensions_api_client.h

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmarks_api.cc ('k') | chrome/browser/extensions/api/chrome_extensions_api_client.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/chrome_extensions_api_client.h

diff --git a/chrome/browser/extensions/api/chrome_extensions_api_client.h b/chrome/browser/extensions/api/chrome_extensions_api_client.h

index 24bdfe2a7ff4193e8a47a68fa3e1d985767a7adb..7f590b3b85fa40dca2caddfd0dd7c3c34afb3084 100644

--- a/chrome/browser/extensions/api/chrome_extensions_api_client.h

+++ b/chrome/browser/extensions/api/chrome_extensions_api_client.h

@@ -24,11 +24,11 @@ class ChromeExtensionsAPIClient : public ExtensionsAPIClient {

observers,

std::map<settings_namespace::Namespace, ValueStoreCache*>* caches)

override;

+ void AttachWebContentsHelpers(content::WebContents* web_contents) const

+ override;

AppViewGuestDelegate* CreateAppViewGuestDelegate() const override;

ExtensionOptionsGuestDelegate* CreateExtensionOptionsGuestDelegate(

ExtensionOptionsGuest* guest) const override;

- ExtensionViewGuestDelegate* CreateExtensionViewGuestDelegate(

- ExtensionViewGuest* guest) const override;

scoped_ptr<MimeHandlerViewGuestDelegate> CreateMimeHandlerViewGuestDelegate(

MimeHandlerViewGuest* guest) const override;

WebViewGuestDelegate* CreateWebViewGuestDelegate(