chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc - Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « apps/custom_launcher_page_contents.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmarks_api.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

index 52cd911374ab410615940bd45be9d07aa157e655..153d4bc4f59a603e00786630c552148a5975031d 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

@@ -545,8 +545,7 @@ bool BookmarkManagerPrivateStartDragFunction::RunOnReady() {

WebContents* web_contents =

WebContents::FromRenderViewHost(render_view_host_);

if (GetViewType(web_contents) == VIEW_TYPE_TAB_CONTENTS) {

- WebContents* web_contents =

- dispatcher()->delegate()->GetAssociatedWebContents();

+ WebContents* web_contents = GetAssociatedWebContents();

CHECK(web_contents);

ui::DragDropTypes::DragEventSource source =

@@ -586,8 +585,7 @@ bool BookmarkManagerPrivateDropFunction::RunOnReady() {