Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3228)

Unified Diff: apps/custom_launcher_page_contents.h

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: apps/custom_launcher_page_contents.h
diff --git a/apps/custom_launcher_page_contents.h b/apps/custom_launcher_page_contents.h
index 919bbe3c2db305031f55bffd95f9544d77427931..cd4164cf08b39bcc5614db04a6e35cd039cf002d 100644
--- a/apps/custom_launcher_page_contents.h
+++ b/apps/custom_launcher_page_contents.h
@@ -7,8 +7,6 @@
#include "base/memory/scoped_ptr.h"
#include "content/public/browser/web_contents_delegate.h"
-#include "content/public/browser/web_contents_observer.h"
-#include "extensions/browser/extension_function_dispatcher.h"
class GURL;
@@ -27,10 +25,7 @@ namespace apps {
// implementation for this class should create and maintain the WebContents for
// the page, and handle any message passing between the web contents and the
// extension system.
-class CustomLauncherPageContents
- : public content::WebContentsDelegate,
- public content::WebContentsObserver,
- public extensions::ExtensionFunctionDispatcher::Delegate {
+class CustomLauncherPageContents : public content::WebContentsDelegate {
public:
CustomLauncherPageContents(scoped_ptr<extensions::AppDelegate> app_delegate,
const std::string& extension_id);
@@ -73,18 +68,7 @@ class CustomLauncherPageContents
content::MediaStreamType type) override;
private:
- // content::WebContentsObserver overrides:
- bool OnMessageReceived(const IPC::Message& message) override;
-
- // extensions::ExtensionFunctionDispatcher::Delegate overrides:
- extensions::WindowController* GetExtensionWindowController() const override;
- content::WebContents* GetAssociatedWebContents() const override;
-
- void OnRequest(const ExtensionHostMsg_Request_Params& params);
-
scoped_ptr<content::WebContents> web_contents_;
- scoped_ptr<extensions::ExtensionFunctionDispatcher>
- extension_function_dispatcher_;
scoped_ptr<extensions::AppDelegate> app_delegate_;
scoped_ptr<extensions::AppWebContentsHelper> helper_;
« no previous file with comments | « no previous file | apps/custom_launcher_page_contents.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698