Make ConnectionSecurityHelper a namespace instead of a class

Make ConnectionSecurityHelper a namespace instead of a class

Instead of having a class with only static methods and an enum, this CL
makes a namespace to contain those functions and enum. The
ConnectionSecurityHelper class is now the
connection_security namespace.

BUG=

Committed: https://crrev.com/d9d78a393048ad53e4dc9f0451c97a7dec0be05a
Cr-Commit-Position: refs/heads/master@{#334386}

[estark, 2015-06-09 21:39:50]

estark@chromium.org changed reviewers:
+ pkasting@chromium.org, rsleevi@chromium.org

[estark, 2015-06-09 21:39:50]

Sorry for the giant diff. :( This is essentially just a rename, but it
unfortunately touches many files. ConnectionSecurityHelper class =>
ConnectionSecurityStatus namespace

pkasting: can you please review //c/b/ui?
rsleevi: can you please review //c/b/ssl?

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
File chrome/browser/ssl/connection_security_status.h (right):

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
chrome/browser/ssl/connection_security_status.h:17: namespace
ConnectionSecurityStatus {
Is naming a namespace like this allowed? (as opposed to e.g. chrome_browser_ssl)

ConnectionSecurityStatus seemed more descriptive than chrome_browser_ssl, and
someone (I forget who) told me that we weren't doing namespaces-named-by-path
anymore. (Though I do remember that the person who told me that couldn't
remember why and couldn't find a citation.)

[Peter Kasting, 2015-06-10 00:09:08]

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
File chrome/browser/ssl/connection_security_status.h (right):

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
chrome/browser/ssl/connection_security_status.h:17: namespace
ConnectionSecurityStatus {
On 2015/06/09 21:39:50, estark wrote:
> Is naming a namespace like this allowed? (as opposed to e.g.
chrome_browser_ssl)

No:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespace_Names

"Namespace names are all lower-case"

The example there makes clear that unix_hacker_style is the appropriate style
for namespace names.

It's possible to name a namespace other than by its pathname.  For example, I
wouldn't be opposed to "connection_security" here.

[estark, 2015-06-10 00:41:15]

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
File chrome/browser/ssl/connection_security_status.h (right):

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
chrome/browser/ssl/connection_security_status.h:17: namespace
ConnectionSecurityStatus {
On 2015/06/10 00:09:08, Peter Kasting wrote:
> On 2015/06/09 21:39:50, estark wrote:
> > Is naming a namespace like this allowed? (as opposed to e.g.
> chrome_browser_ssl)
> 
> No:
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespace_Names
> 
> "Namespace names are all lower-case"
> 
> The example there makes clear that unix_hacker_style is the appropriate style
> for namespace names.
> 
> It's possible to name a namespace other than by its pathname.  For example, I
> wouldn't be opposed to "connection_security" here.

Ah, ok, I missed that, thanks. I renamed it to connection_security_status. (Do
you prefer connection_security over connection_security_status?)

[Peter Kasting, 2015-06-10 01:53:37]

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
File chrome/browser/ssl/connection_security_status.h (right):

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
chrome/browser/ssl/connection_security_status.h:17: namespace
ConnectionSecurityStatus {
On 2015/06/10 00:41:15, estark wrote:
> On 2015/06/10 00:09:08, Peter Kasting wrote:
> > On 2015/06/09 21:39:50, estark wrote:
> > > Is naming a namespace like this allowed? (as opposed to e.g.
> > chrome_browser_ssl)
> > 
> > No:
> >
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespace_Names
> > 
> > "Namespace names are all lower-case"
> > 
> > The example there makes clear that unix_hacker_style is the appropriate
style
> > for namespace names.
> > 
> > It's possible to name a namespace other than by its pathname.  For example,
I
> > wouldn't be opposed to "connection_security" here.
> 
> Ah, ok, I missed that, thanks. I renamed it to connection_security_status. (Do
> you prefer connection_security over connection_security_status?) 

I don't have a strong preference, the former just seemed shorter and potentially
more flexible if this were ever to include something other than getters, without
losing much clarity.

[estark, 2015-06-10 04:16:17]

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
File chrome/browser/ssl/connection_security_status.h (right):

https://codereview.chromium.org/1169213006/diff/1/chrome/browser/ssl/connecti...
chrome/browser/ssl/connection_security_status.h:17: namespace
ConnectionSecurityStatus {
On 2015/06/10 01:53:36, Peter Kasting wrote:
> On 2015/06/10 00:41:15, estark wrote:
> > On 2015/06/10 00:09:08, Peter Kasting wrote:
> > > On 2015/06/09 21:39:50, estark wrote:
> > > > Is naming a namespace like this allowed? (as opposed to e.g.
> > > chrome_browser_ssl)
> > > 
> > > No:
> > >
> >
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespace_Names
> > > 
> > > "Namespace names are all lower-case"
> > > 
> > > The example there makes clear that unix_hacker_style is the appropriate
> style
> > > for namespace names.
> > > 
> > > It's possible to name a namespace other than by its pathname.  For
example,
> I
> > > wouldn't be opposed to "connection_security" here.
> > 
> > Ah, ok, I missed that, thanks. I renamed it to connection_security_status.
(Do
> > you prefer connection_security over connection_security_status?) 
> 
> I don't have a strong preference, the former just seemed shorter and
potentially
> more flexible if this were ever to include something other than getters,
without
> losing much clarity.

Fair enough; changed to connection_security.

[Peter Kasting, 2015-06-11 00:24:40]

LGTM

https://codereview.chromium.org/1169213006/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/1169213006/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:438:
connection_security::EV_SECURE)) {
Nit: While here: There's an extra set of parens around the whole expr

[Ryan Sleevi, 2015-06-11 00:26:04]

c/b/ssl LGTM

[estark, 2015-06-11 00:38:22]

estark@chromium.org changed reviewers:
+ tedchoc@chromium.org

[estark, 2015-06-11 00:38:23]

Thank you pkasting and rsleevi.

tedchoc: could you please review //chrome/android and //chrome/browser/android?
This is a rename; the ConnectionSecurityHelper class became the
connection_security namespace, which entailed some renames in Java and a new
name for the generated Java enum.

https://codereview.chromium.org/1169213006/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/1169213006/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:438:
connection_security::EV_SECURE)) {
On 2015/06/11 00:24:40, Peter Kasting wrote:
> Nit: While here: There's an extra set of parens around the whole expr

Done.

[Ted C, 2015-06-11 20:29:52]

On 2015/06/11 00:38:23, estark wrote:
> Thank you pkasting and rsleevi.
> 
> tedchoc: could you please review //chrome/android and
//chrome/browser/android?
> This is a rename; the ConnectionSecurityHelper class became the
> connection_security namespace, which entailed some renames in Java and a new
> name for the generated Java enum.
> 
>
https://codereview.chromium.org/1169213006/diff/60001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):
> 
>
https://codereview.chromium.org/1169213006/diff/60001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:438:
> connection_security::EV_SECURE)) {
> On 2015/06/11 00:24:40, Peter Kasting wrote:
> > Nit: While here: There's an extra set of parens around the whole expr
> 
> Done.

lgtm

[estark, 2015-06-11 20:31:56]

The CQ bit was checked by estark@chromium.org

[estark, 2015-06-11 20:31:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1169213006/#ps80001
(title: "remove extra set of parens")

[commit-bot: I haz the power, 2015-06-11 20:34:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169213006/80001

[commit-bot: I haz the power, 2015-06-11 20:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 20:39:36]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[estark, 2015-06-11 22:32:18]

The CQ bit was checked by estark@chromium.org

[estark, 2015-06-11 22:32:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, pkasting@chromium.org, rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1169213006/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-11 22:34:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169213006/100001

[commit-bot: I haz the power, 2015-06-11 22:46:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 22:46:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[estark, 2015-06-11 23:16:34]

estark@chromium.org changed reviewers:
+ sky@chromium.org

[estark, 2015-06-11 23:16:35]

sky: can you please review chrome/chrome.gyp?

[sky, 2015-06-15 14:41:37]

chrome.gyp LGTM

[estark, 2015-06-15 14:43:52]

The CQ bit was checked by estark@chromium.org

[estark, 2015-06-15 14:43:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, pkasting@chromium.org, rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1169213006/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-15 14:44:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169213006/140001

[commit-bot: I haz the power, 2015-06-15 16:11:03]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-06-15 16:12:04]

Patchset 8 (id:??) landed as
https://crrev.com/d9d78a393048ad53e4dc9f0451c97a7dec0be05a
Cr-Commit-Position: refs/heads/master@{#334386}