Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java

Issue 1169213006: Make ConnectionSecurityHelper a namespace instead of a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
index 555d2dc580c83b7f809c2e2e0ace4b8b73709f8b..5665568f06832a6923d44ab306588f4975629066 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
@@ -47,8 +47,8 @@ import org.chromium.chrome.browser.preferences.Preferences;
import org.chromium.chrome.browser.preferences.PreferencesLauncher;
import org.chromium.chrome.browser.preferences.website.SingleWebsitePreferences;
import org.chromium.chrome.browser.profiles.Profile;
-import org.chromium.chrome.browser.ssl.ConnectionSecurityHelper;
-import org.chromium.chrome.browser.ssl.ConnectionSecurityHelperSecurityLevel;
+import org.chromium.chrome.browser.ssl.ConnectionSecurity;
+import org.chromium.chrome.browser.ssl.ConnectionSecurityLevel;
import org.chromium.chrome.browser.toolbar.ToolbarModel;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.WebContentsObserver;
@@ -250,7 +250,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
// chrome://settings page).
private boolean mIsInternalPage;
- // The security level of the page (a valid ConnectionSecurityHelperSecurityLevel).
+ // The security level of the page (a valid ConnectionSecurityLevel).
private int mSecurityLevel;
// Whether the security level of the page was deprecated due to SHA-1.
@@ -395,7 +395,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
mParsedUrl = null;
mIsInternalPage = false;
}
- mSecurityLevel = ConnectionSecurityHelper.getSecurityLevelForWebContents(mWebContents);
+ mSecurityLevel = ConnectionSecurity.getSecurityLevelForWebContents(mWebContents);
mDeprecatedSHA1Present = ToolbarModel.isDeprecatedSHA1Present(mWebContents);
SpannableStringBuilder urlBuilder = new SpannableStringBuilder(mFullUrl);
@@ -464,7 +464,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
* Gets the message to display in the connection message box for the given security level. Does
* not apply to SECURITY_ERROR pages, since these have their own coloured/formatted message.
*
- * @param securityLevel A valid ConnectionSecurityHelperSecurityLevel, which is the security
+ * @param securityLevel A valid ConnectionSecurityLevel, which is the security
* level of the page.
* @param isInternalPage Whether or not this page is an internal chrome page (e.g. the
* chrome://settings page).
@@ -474,13 +474,13 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
if (isInternalPage) return R.string.page_info_connection_internal_page;
switch (securityLevel) {
- case ConnectionSecurityHelperSecurityLevel.NONE:
+ case ConnectionSecurityLevel.NONE:
return R.string.page_info_connection_http;
- case ConnectionSecurityHelperSecurityLevel.SECURE:
- case ConnectionSecurityHelperSecurityLevel.EV_SECURE:
+ case ConnectionSecurityLevel.SECURE:
+ case ConnectionSecurityLevel.EV_SECURE:
return R.string.page_info_connection_https;
- case ConnectionSecurityHelperSecurityLevel.SECURITY_WARNING:
- case ConnectionSecurityHelperSecurityLevel.SECURITY_POLICY_WARNING:
+ case ConnectionSecurityLevel.SECURITY_WARNING:
+ case ConnectionSecurityLevel.SECURITY_POLICY_WARNING:
return R.string.page_info_connection_mixed;
default:
assert false : "Invalid security level specified: " + securityLevel;
@@ -493,7 +493,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
* HTTPS connections.
*/
private boolean isConnectionDetailsLinkVisible() {
- return !mIsInternalPage && mSecurityLevel != ConnectionSecurityHelperSecurityLevel.NONE;
+ return !mIsInternalPage && mSecurityLevel != ConnectionSecurityLevel.NONE;
}
/**
@@ -505,7 +505,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
if (mDeprecatedSHA1Present) {
messageBuilder.append(
mContext.getResources().getString(R.string.page_info_connection_sha1));
- } else if (mSecurityLevel != ConnectionSecurityHelperSecurityLevel.SECURITY_ERROR) {
+ } else if (mSecurityLevel != ConnectionSecurityLevel.SECURITY_ERROR) {
messageBuilder.append(mContext.getResources().getString(
getConnectionMessageId(mSecurityLevel, mIsInternalPage)));
} else {

Powered by Google App Engine
This is Rietveld 408576698