Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1169033003: Disable direction pre-caching to suss out TSAN failures. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable direction pre-caching to suss out TSAN failures. Our bots don't seem to mind / see the race... let's see if Chrome's do. BUG=chromium:496982 TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/256cc89c486aaa1f1398b6f99a18814e59a1b7fb

Patch Set 1 #

Patch Set 2 : hacking to see the race #

Patch Set 3 : draw a path too #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/core/SkRecords.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 6 months ago (2015-06-10 14:39:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169033003/1
5 years, 6 months ago (2015-06-10 14:40:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-10 14:46:38 UTC) #6
mtklein
lgtm
5 years, 6 months ago (2015-06-15 19:22:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169033003/60001
5 years, 6 months ago (2015-06-15 19:22:22 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 19:27:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/256cc89c486aaa1f1398b6f99a18814e59a1b7fb

Powered by Google App Engine
This is Rietveld 408576698