Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: services/native_viewport/native_viewport_impl.h

Issue 1168993002: Update the native_viewport interface to allow specification of the surface configuration, currently… (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Requested fixes and a few other minor corrections Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/native_viewport/native_viewport_impl.h
diff --git a/services/native_viewport/native_viewport_impl.h b/services/native_viewport/native_viewport_impl.h
index 4ac9bbd02138e312587ca9cd942448d46a9ee8fc..d207fd4b10e39ed7723454b99741e8cb209c7fe1 100644
--- a/services/native_viewport/native_viewport_impl.h
+++ b/services/native_viewport/native_viewport_impl.h
@@ -40,12 +40,14 @@ class NativeViewportImpl : public mojo::NativeViewport,
~NativeViewportImpl() override;
// NativeViewport implementation.
- void Create(mojo::SizePtr size, const CreateCallback& callback) override;
+ void Create(const mojo::SizePtr size,
qsr 2015/06/09 11:02:52 Why this const? And the underlying ones? You are t
iansf 2015/06/09 17:23:24 Done.
+ mojo::SurfaceConfigurationPtr requested_configuration,
+ const CreateCallback& callback) override;
void RequestMetrics(const RequestMetricsCallback& callback) override;
void Show() override;
void Hide() override;
void Close() override;
- void SetSize(mojo::SizePtr size) override;
+ void SetSize(const mojo::SizePtr size) override;
void GetContextProvider(
mojo::InterfaceRequest<mojo::ContextProvider> request) override;
void SetEventDispatcher(

Powered by Google App Engine
This is Rietveld 408576698