Update the native_viewport interface to allow specification of the surface configuration, currently…

services/native_viewport/native_viewport_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_NATIVE_VIEWPORT_NATIVE_VIEWPORT_IMPL_H_
 #define SERVICES_NATIVE_VIEWPORT_NATIVE_VIEWPORT_IMPL_H_
 
 #include <set>
 
 #include "base/macros.h"
@@ skipping 22 matching lines @@
 class NativeViewportImpl : public mojo::NativeViewport,
                            public PlatformViewport::Delegate,
                            public mojo::ErrorHandler {
  public:
   NativeViewportImpl(bool is_headless,
                      const scoped_refptr<gles2::GpuState>& gpu_state,
                      mojo::InterfaceRequest<mojo::NativeViewport> request);
   ~NativeViewportImpl() override;
 
   // NativeViewport implementation.
-  void Create(mojo::SizePtr size, const CreateCallback& callback) override;
+  void Create(const mojo::SizePtr size,

[qsr, 2015/06/09 11:02:52]

Why this const? And the underlying ones? You are taking ownership of these
objects, so marking them const is kind of weird.

[iansf, 2015/06/09 17:23:24]

Done.

+              mojo::SurfaceConfigurationPtr requested_configuration,
+              const CreateCallback& callback) override;
   void RequestMetrics(const RequestMetricsCallback& callback) override;
   void Show() override;
   void Hide() override;
   void Close() override;
-  void SetSize(mojo::SizePtr size) override;
+  void SetSize(const mojo::SizePtr size) override;
   void GetContextProvider(
       mojo::InterfaceRequest<mojo::ContextProvider> request) override;
   void SetEventDispatcher(
       mojo::NativeViewportEventDispatcherPtr dispatcher) override;
 
   // PlatformViewport::Delegate implementation.
   void OnMetricsChanged(mojo::ViewportMetricsPtr metrics) override;
   void OnAcceleratedWidgetAvailable(gfx::AcceleratedWidget widget) override;
   void OnAcceleratedWidgetDestroyed() override;
   bool OnEvent(mojo::EventPtr event) override;
@@ skipping 22 matching lines @@
   std::set<int32> pointers_waiting_on_ack_;
 
   base::WeakPtrFactory<NativeViewportImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeViewportImpl);
 };
 
 }  // namespace native_viewport
 
 #endif  // SERVICES_NATIVE_VIEWPORT_NATIVE_VIEWPORT_IMPL_H_